Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Improve v8 upgrade notes for SQL data sources #38792

Merged
merged 8 commits into from
Sep 10, 2021
Merged

Docs: Improve v8 upgrade notes for SQL data sources #38792

merged 8 commits into from
Sep 10, 2021

Conversation

marefr
Copy link
Member

@marefr marefr commented Sep 1, 2021

What this PR does / why we need it:
Improves SQL data sources documentation in regards to Grafana 8 changes and adds some additional upgrade notes in regards to this.

Which issue(s) this PR fixes:
Ref #35390
Ref #38666

Special notes for your reviewer:

@marefr marefr requested review from pkolyvas and a team as code owners September 1, 2021 15:42
@marefr marefr requested review from achatterjee-grafana, Eve832 and torkelo and removed request for a team September 1, 2021 15:42
@marefr marefr added this to In progress in Grafana Backend (DO NOT USE!) via automation Sep 1, 2021
@marefr marefr moved this from In progress to Under review in Grafana Backend (DO NOT USE!) Sep 1, 2021
@marefr marefr added old backport v8.0.x Mark PR for automatic backport to v8.0.x old backport v8.1.x Mark PR for automatic backport to v8.1.x labels Sep 1, 2021
@marefr marefr added this to the 8.2.0 milestone Sep 1, 2021
Copy link
Member

@torkelo torkelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth mentioning that string fields get transformed into labels when time series format it selected. And an example of how you only show a specific label using the display name variable expression.

Copy link
Contributor

@achatterjee-grafana achatterjee-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added partial doc review, more to come.

docs/sources/datasources/mssql.md Outdated Show resolved Hide resolved
marefr and others added 2 commits September 2, 2021 10:35
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
Copy link
Member

@torkelo torkelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great

@marefr
Copy link
Member Author

marefr commented Sep 10, 2021

Changed MSSQL quite a bit to make its examples more in line with Postgres and MSSQL and by that removed some screenshots.

Copy link
Contributor

@achatterjee-grafana achatterjee-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added doc review.

docs/sources/datasources/mssql.md Outdated Show resolved Hide resolved
docs/sources/datasources/mssql.md Outdated Show resolved Hide resolved
docs/sources/datasources/mssql.md Outdated Show resolved Hide resolved
docs/sources/datasources/mssql.md Outdated Show resolved Hide resolved
docs/sources/installation/upgrading.md Outdated Show resolved Hide resolved
docs/sources/installation/upgrading.md Outdated Show resolved Hide resolved
docs/sources/installation/upgrading.md Outdated Show resolved Hide resolved
docs/sources/installation/upgrading.md Outdated Show resolved Hide resolved
docs/sources/datasources/postgres.md Outdated Show resolved Hide resolved
docs/sources/datasources/mysql.md Outdated Show resolved Hide resolved
marefr and others added 2 commits September 10, 2021 16:59
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
Copy link
Contributor

@achatterjee-grafana achatterjee-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marefr marefr enabled auto-merge (squash) September 10, 2021 15:14
@marefr marefr merged commit 0bb7d50 into main Sep 10, 2021
Grafana Backend (DO NOT USE!) automation moved this from Under review to Done Sep 10, 2021
@marefr marefr deleted the 38666_docs branch September 10, 2021 15:38
@grafanabot
Copy link
Contributor

The backport to v8.0.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-38792-to-v8.0.x origin/v8.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 0bb7d50ad62181544a001b43ea0f8e7935548095
# Push it to GitHub
git push --set-upstream origin backport-38792-to-v8.0.x
git switch main
# Remove the local backport branch
git branch -D backport-38792-to-v8.0.x

Then, create a pull request where the base branch is v8.0.x and the compare/head branch is backport-38792-to-v8.0.x.

@grafanabot
Copy link
Contributor

The backport to v8.1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-38792-to-v8.1.x origin/v8.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 0bb7d50ad62181544a001b43ea0f8e7935548095
# Push it to GitHub
git push --set-upstream origin backport-38792-to-v8.1.x
git switch main
# Remove the local backport branch
git branch -D backport-38792-to-v8.1.x

Then, create a pull request where the base branch is v8.1.x and the compare/head branch is backport-38792-to-v8.1.x.

marefr added a commit that referenced this pull request Sep 13, 2021
Improves SQL data sources documentation in regards to Grafana 8 changes
and adds some additional upgrade notes in regards to this.

Ref #35390
Ref #38666

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
(cherry picked from commit 0bb7d50)
marefr added a commit that referenced this pull request Sep 13, 2021
Improves SQL data sources documentation in regards to Grafana 8 changes
and adds some additional upgrade notes in regards to this.

Ref #35390
Ref #38666

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
(cherry picked from commit 0bb7d50)
marefr added a commit that referenced this pull request Sep 13, 2021
Improves SQL data sources documentation in regards to Grafana 8 changes
and adds some additional upgrade notes in regards to this.

Ref #35390
Ref #38666

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
(cherry picked from commit 0bb7d50)
marefr added a commit that referenced this pull request Sep 13, 2021
Improves SQL data sources documentation in regards to Grafana 8 changes
and adds some additional upgrade notes in regards to this.

Ref #35390
Ref #38666

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
(cherry picked from commit 0bb7d50)
stevepostill pushed a commit to Reveal-International/grafana that referenced this pull request Nov 3, 2021
…-github to revdev

* commit '56aebaac32bd7a82f84a571969b51c62ba54fd6d': (23 commits)
  "Release: Updated versions in package to 8.1.4" (grafana#39273)
  Docs: Update azuread docs to mention about env variables (grafana#39203) (grafana#39265)
  Docs: plugin migration guide 7.0.0 to 8.0.0 (grafana#38911) (grafana#39246)
  Docs: Added "manageAlerts" provisioning option. (grafana#38836) (grafana#39253)
  BarChart: Fix legend and tooltip colors off by 1 after data refresh (grafana#39234) (grafana#39252)
  Update silences.md (grafana#38834) (grafana#39243)
  Explore: Ensure logs volume bar colors match legend colors (grafana#39072) (grafana#39120)
  Graph: make old graph panel thresholds work even if ngalert is enabled  (grafana#38918) (grafana#39233)
  Fix regex to identify / as separator (grafana#39220)
  [v8.1.x] BarChart: fix stale bar values and x axis labels
  Add link to default template (grafana#39106) (grafana#39138)
  Doc: Created a separate topic for AWS authentication  (grafana#39012) (grafana#39160)
  LDAP: Search all DNs for users (grafana#38891) (grafana#39167)
  Docs: Fix broken link to signed GCS URLs docs (grafana#39144) (grafana#39149)
  [v8.1.x] Variables: Fix not updating inside a Panel when the preceding Row uses "Repeat For" (grafana#39141)
  Docs: Improve v8 upgrade notes for SQL data sources (grafana#38792) (grafana#39124)
  Explore: Trace view now shows trace start time in selected timezone (grafana#39054) (grafana#39093)
  Alerting: Fix notification channel migration (grafana#38983) (grafana#39053)
  Annotations: Fixes blank panels for queries with unknown data sources (grafana#39017) (grafana#39034)
  Copy cue.mod and packages/grafana-schema to container workdir (grafana#38998) (grafana#39018)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old backport v8.0.x Mark PR for automatic backport to v8.0.x old backport v8.1.x Mark PR for automatic backport to v8.1.x type/docs
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants