Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore: Ensure logs volume bar colors match legend colors #39072

Merged
merged 2 commits into from
Sep 13, 2021

Conversation

ifrost
Copy link
Contributor

@ifrost ifrost commented Sep 10, 2021

What this PR does / why we need it:

The color for the legend was not set up causing a mismatch in bars/legend colors.

Which issue(s) this PR fixes:

Fixes #38827

Special notes for your reviewer:

How to test it?

  • load logs with levels
  • select level from the legend below the graph:-the color in the legend should match the color of visible bars
before after
Screen Shot 2021-09-10 at 10 38 27 Screen Shot 2021-09-10 at 10 39 30

Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎨

@ivanahuckova
Copy link
Member

Shouldn't this be also backported and part of next 8.1.x?

@ifrost ifrost added the old backport v8.1.x Mark PR for automatic backport to v8.1.x label Sep 13, 2021
@ifrost ifrost merged commit 88ad9aa into main Sep 13, 2021
@ifrost ifrost deleted the ifrost/explore-logs-volume-legend-colors branch September 13, 2021 09:11
grafanabot pushed a commit that referenced this pull request Sep 13, 2021
* Ensure logs volume bar colors match legend colors

* Fix tests

(cherry picked from commit 88ad9aa)
@ivanahuckova ivanahuckova modified the milestones: 8.2.0, 8.1.4 Sep 13, 2021
@ivanahuckova
Copy link
Member

ivanahuckova commented Sep 13, 2021

I've notices that the milestone was 8.2 so I updated it and added add to changelog. :)

ifrost added a commit that referenced this pull request Sep 15, 2021
…39120)

* Ensure logs volume bar colors match legend colors

* Fix tests

(cherry picked from commit 88ad9aa)

Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>
@sunker sunker added this to the 8.1.4 milestone Sep 16, 2021
stevepostill pushed a commit to Reveal-International/grafana that referenced this pull request Nov 3, 2021
…-github to revdev

* commit '56aebaac32bd7a82f84a571969b51c62ba54fd6d': (23 commits)
  "Release: Updated versions in package to 8.1.4" (grafana#39273)
  Docs: Update azuread docs to mention about env variables (grafana#39203) (grafana#39265)
  Docs: plugin migration guide 7.0.0 to 8.0.0 (grafana#38911) (grafana#39246)
  Docs: Added "manageAlerts" provisioning option. (grafana#38836) (grafana#39253)
  BarChart: Fix legend and tooltip colors off by 1 after data refresh (grafana#39234) (grafana#39252)
  Update silences.md (grafana#38834) (grafana#39243)
  Explore: Ensure logs volume bar colors match legend colors (grafana#39072) (grafana#39120)
  Graph: make old graph panel thresholds work even if ngalert is enabled  (grafana#38918) (grafana#39233)
  Fix regex to identify / as separator (grafana#39220)
  [v8.1.x] BarChart: fix stale bar values and x axis labels
  Add link to default template (grafana#39106) (grafana#39138)
  Doc: Created a separate topic for AWS authentication  (grafana#39012) (grafana#39160)
  LDAP: Search all DNs for users (grafana#38891) (grafana#39167)
  Docs: Fix broken link to signed GCS URLs docs (grafana#39144) (grafana#39149)
  [v8.1.x] Variables: Fix not updating inside a Panel when the preceding Row uses "Repeat For" (grafana#39141)
  Docs: Improve v8 upgrade notes for SQL data sources (grafana#38792) (grafana#39124)
  Explore: Trace view now shows trace start time in selected timezone (grafana#39054) (grafana#39093)
  Alerting: Fix notification channel migration (grafana#38983) (grafana#39053)
  Annotations: Fixes blank panels for queries with unknown data sources (grafana#39017) (grafana#39034)
  Copy cue.mod and packages/grafana-schema to container workdir (grafana#38998) (grafana#39018)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore: colors on the graph legend are mismatched, when showing loki logs.
4 participants