Doc: Created a separate topic for AWS authentication #39012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achatterjee-grafana
requested review from
pkolyvas and
a team
as code owners
achatterjee-grafana
requested review from
osg-grafana,
Eve832 and
sunker
and removed request for
a team
achatterjee-grafana
added
the
old backport v8.1.x
osg-grafana
reviewed
Sep 9, 2021
Eve832
approved these changes
Sep 9, 2021
pkolyvas
approved these changes
Sep 9, 2021
GrafanaWriter
approved these changes
Sep 9, 2021
sunker
reviewed
Sep 10, 2021
There was a problem hiding this comment.
Looks great! A few comments from me:
docs/sources/datasources/aws-cloudwatch/aws-authentication.md . Does this have to live under the aws-cloudwatch directory? Maybe it can be docs/sources/datasources/aws/aws-authentication.md?
When it comes to auth options, there's actually four options. The first three, AWS SDK Default, Credentials file and Access & secret key are enabled by default in open source grafana. The fourth, and currently undocumented option, is called Workspace IAM role role. This new option (and Access & secret key) are enabled by default in AMG. I can take a stab at writing a draft for the new, undocumented auth option.
Anyone who can access the server configuration of Grafana can enable/disable this authentication options. This is documented here, but I think it would be great if we describe that shortly in this document and link to the configuration.
Currently, everything in the aws-authentication.md file is generic information that applies to any AWS data source except for the part about IAM policies, so this section needs to be described in each separate data source documentation.
Co-authored-by: Fiona Artiaga <89225282+GrafanaWriter@users.noreply.github.com>
achatterjee-grafana
deleted the
Doc-Move-AWS-authetication-to-separate-topic
branch
grafanabot
pushed a commit
that referenced
this pull request
Sep 13, 2021
* Created new topic for AWS authentication and fixed broken relrefs. * Applied suggestion from review. * Update docs/sources/datasources/aws-cloudwatch/aws-authentication.md Co-authored-by: Fiona Artiaga <89225282+GrafanaWriter@users.noreply.github.com> * Applied some suggestions from doc review. * Applied all doc review. * Last of the edits, went through and addressed all comments. Co-authored-by: Fiona Artiaga <89225282+GrafanaWriter@users.noreply.github.com> (cherry picked from commit d3a7e02)
achatterjee-grafana
added a commit
that referenced
this pull request
Sep 14, 2021
* Created new topic for AWS authentication and fixed broken relrefs. * Applied suggestion from review. * Update docs/sources/datasources/aws-cloudwatch/aws-authentication.md Co-authored-by: Fiona Artiaga <89225282+GrafanaWriter@users.noreply.github.com> * Applied some suggestions from doc review. * Applied all doc review. * Last of the edits, went through and addressed all comments. Co-authored-by: Fiona Artiaga <89225282+GrafanaWriter@users.noreply.github.com> (cherry picked from commit d3a7e02) Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
stevepostill
pushed a commit
to Reveal-International/grafana
that referenced
this pull request
Nov 3, 2021
…-github to revdev * commit '56aebaac32bd7a82f84a571969b51c62ba54fd6d': (23 commits) "Release: Updated versions in package to 8.1.4" (grafana#39273) Docs: Update azuread docs to mention about env variables (grafana#39203) (grafana#39265) Docs: plugin migration guide 7.0.0 to 8.0.0 (grafana#38911) (grafana#39246) Docs: Added "manageAlerts" provisioning option. (grafana#38836) (grafana#39253) BarChart: Fix legend and tooltip colors off by 1 after data refresh (grafana#39234) (grafana#39252) Update silences.md (grafana#38834) (grafana#39243) Explore: Ensure logs volume bar colors match legend colors (grafana#39072) (grafana#39120) Graph: make old graph panel thresholds work even if ngalert is enabled (grafana#38918) (grafana#39233) Fix regex to identify / as separator (grafana#39220) [v8.1.x] BarChart: fix stale bar values and x axis labels Add link to default template (grafana#39106) (grafana#39138) Doc: Created a separate topic for AWS authentication (grafana#39012) (grafana#39160) LDAP: Search all DNs for users (grafana#38891) (grafana#39167) Docs: Fix broken link to signed GCS URLs docs (grafana#39144) (grafana#39149) [v8.1.x] Variables: Fix not updating inside a Panel when the preceding Row uses "Repeat For" (grafana#39141) Docs: Improve v8 upgrade notes for SQL data sources (grafana#38792) (grafana#39124) Explore: Trace view now shows trace start time in selected timezone (grafana#39054) (grafana#39093) Alerting: Fix notification channel migration (grafana#38983) (grafana#39053) Annotations: Fixes blank panels for queries with unknown data sources (grafana#39017) (grafana#39034) Copy cue.mod and packages/grafana-schema to container workdir (grafana#38998) (grafana#39018) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the conversation in this discussion: #38112
Since the RedShift and Athena docs still live in their own repo, we needed an HTTP URL and could not do single sourcing in the truest sense yet. We will tackle that later.
Checked and fixed broken relrefs.