Docs: Update azuread docs to mention about env variables #39203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a note about the name of the environment variables to be used for configuring client_id and client_secret
ghost
requested review from
osg-grafana and
Eve832
and removed request for
a team
|
|
There was a problem hiding this comment.
Minor copy edit suggestions. Also needs a dev review, tagging @joshhunt
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
achatterjee-grafana
requested review from
a team,
sarahzinger and
vickyyyyyyy
and removed request for
a team
achatterjee-grafana
added
the
old backport v8.1.x
joshhunt
requested review from
a team,
sdboyer and
malcolmholmes
and removed request for
sarahzinger,
vickyyyyyyy and
a team
added 2 commits
September 15, 2021 10:29
This reverts commit ff84f70.
achatterjee-grafana
approved these changes
Sep 15, 2021
|
@sdboyer and @malcolmholmes can one of you review this PR so that we can get this merged for 8.1.4. Thank you. |
sdboyer
approved these changes
Sep 15, 2021
grafanabot
pushed a commit
that referenced
this pull request
Sep 16, 2021
* Update azuread docs to mention about env variables Add a note about the name of the environment variables to be used for configuring client_id and client_secret * Update docs/sources/auth/azuread.md Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * Update docs/sources/auth/azuread.md Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * fix typo * Revert "fix typo" This reverts commit ff84f70. * Fixed typo again, trying to kick start license check. Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> Co-authored-by: achatterjee-grafana <aparajita.chatterjee@grafana.com> (cherry picked from commit b5ed47c)
achatterjee-grafana
pushed a commit
that referenced
this pull request
Sep 16, 2021
…9265) * Update azuread docs to mention about env variables Add a note about the name of the environment variables to be used for configuring client_id and client_secret * Update docs/sources/auth/azuread.md Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * Update docs/sources/auth/azuread.md Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * fix typo * Revert "fix typo" This reverts commit ff84f70. * Fixed typo again, trying to kick start license check. Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> Co-authored-by: achatterjee-grafana <aparajita.chatterjee@grafana.com> (cherry picked from commit b5ed47c) Co-authored-by: rodrigosilva-ciandt <84101915+rodrigosilva-ciandt@users.noreply.github.com>
stevepostill
pushed a commit
to Reveal-International/grafana
that referenced
this pull request
Nov 3, 2021
…-github to revdev * commit '56aebaac32bd7a82f84a571969b51c62ba54fd6d': (23 commits) "Release: Updated versions in package to 8.1.4" (grafana#39273) Docs: Update azuread docs to mention about env variables (grafana#39203) (grafana#39265) Docs: plugin migration guide 7.0.0 to 8.0.0 (grafana#38911) (grafana#39246) Docs: Added "manageAlerts" provisioning option. (grafana#38836) (grafana#39253) BarChart: Fix legend and tooltip colors off by 1 after data refresh (grafana#39234) (grafana#39252) Update silences.md (grafana#38834) (grafana#39243) Explore: Ensure logs volume bar colors match legend colors (grafana#39072) (grafana#39120) Graph: make old graph panel thresholds work even if ngalert is enabled (grafana#38918) (grafana#39233) Fix regex to identify / as separator (grafana#39220) [v8.1.x] BarChart: fix stale bar values and x axis labels Add link to default template (grafana#39106) (grafana#39138) Doc: Created a separate topic for AWS authentication (grafana#39012) (grafana#39160) LDAP: Search all DNs for users (grafana#38891) (grafana#39167) Docs: Fix broken link to signed GCS URLs docs (grafana#39144) (grafana#39149) [v8.1.x] Variables: Fix not updating inside a Panel when the preceding Row uses "Repeat For" (grafana#39141) Docs: Improve v8 upgrade notes for SQL data sources (grafana#38792) (grafana#39124) Explore: Trace view now shows trace start time in selected timezone (grafana#39054) (grafana#39093) Alerting: Fix notification channel migration (grafana#38983) (grafana#39053) Annotations: Fixes blank panels for queries with unknown data sources (grafana#39017) (grafana#39034) Copy cue.mod and packages/grafana-schema to container workdir (grafana#38998) (grafana#39018) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a note about the name of the environment variables to be used for configuring client_id and client_secret
It's not clear that the name of the variables should be AZUREAD
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: