Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BarChart: fix legend and tooltip colors off by 1 after data refresh #39234

Merged
merged 3 commits into from
Sep 15, 2021

Conversation

leeoniya
Copy link
Contributor

fix by always re-enumerating state.seriesIndex during frame prep, not just during initial config.

bars-legend-tooltip-colors.mp4

@leeoniya leeoniya added type/bug area/panel/barchart old backport v8.1.x Mark PR for automatic backport to v8.1.x labels Sep 15, 2021
@leeoniya leeoniya added this to the 8.2.0 milestone Sep 15, 2021
@leeoniya leeoniya requested review from torkelo, ryantxu, dprokop and a team and removed request for a team September 15, 2021 13:30
@leeoniya leeoniya modified the milestones: 8.2.0, 8.1.4 Sep 15, 2021
@leeoniya leeoniya merged commit fb091de into main Sep 15, 2021
@leeoniya leeoniya deleted the leeoniya/barchart-fix-legend-colors branch September 15, 2021 18:10
grafanabot pushed a commit that referenced this pull request Sep 15, 2021
leeoniya added a commit that referenced this pull request Sep 15, 2021
…39234) (#39252)

(cherry picked from commit fb091de)

Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
@sunker sunker added this to the 8.1.4 milestone Sep 16, 2021
stevepostill pushed a commit to Reveal-International/grafana that referenced this pull request Nov 3, 2021
…-github to revdev

* commit '56aebaac32bd7a82f84a571969b51c62ba54fd6d': (23 commits)
  "Release: Updated versions in package to 8.1.4" (grafana#39273)
  Docs: Update azuread docs to mention about env variables (grafana#39203) (grafana#39265)
  Docs: plugin migration guide 7.0.0 to 8.0.0 (grafana#38911) (grafana#39246)
  Docs: Added "manageAlerts" provisioning option. (grafana#38836) (grafana#39253)
  BarChart: Fix legend and tooltip colors off by 1 after data refresh (grafana#39234) (grafana#39252)
  Update silences.md (grafana#38834) (grafana#39243)
  Explore: Ensure logs volume bar colors match legend colors (grafana#39072) (grafana#39120)
  Graph: make old graph panel thresholds work even if ngalert is enabled  (grafana#38918) (grafana#39233)
  Fix regex to identify / as separator (grafana#39220)
  [v8.1.x] BarChart: fix stale bar values and x axis labels
  Add link to default template (grafana#39106) (grafana#39138)
  Doc: Created a separate topic for AWS authentication  (grafana#39012) (grafana#39160)
  LDAP: Search all DNs for users (grafana#38891) (grafana#39167)
  Docs: Fix broken link to signed GCS URLs docs (grafana#39144) (grafana#39149)
  [v8.1.x] Variables: Fix not updating inside a Panel when the preceding Row uses "Repeat For" (grafana#39141)
  Docs: Improve v8 upgrade notes for SQL data sources (grafana#38792) (grafana#39124)
  Explore: Trace view now shows trace start time in selected timezone (grafana#39054) (grafana#39093)
  Alerting: Fix notification channel migration (grafana#38983) (grafana#39053)
  Annotations: Fixes blank panels for queries with unknown data sources (grafana#39017) (grafana#39034)
  Copy cue.mod and packages/grafana-schema to container workdir (grafana#38998) (grafana#39018)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants