Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix broken link to signed GCS URLs docs #39144

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

jorgelbg
Copy link
Contributor

What this PR does / why we need it:

The current version of the docs contains a broken link to the GCS docs about signed URLs. The link (since it contains an additional ]) generates a 404 and also slightly breaks the rendering of the link.

Which issue(s) this PR fixes:

None

The current version of the docs contains a broken link to the GCS docs about signed URLs. The link (since it contains an additional `]`) generates a 404 and also slightly breaks the rendering of the link.
@jorgelbg jorgelbg requested review from pkolyvas and a team as code owners September 13, 2021 15:38
@jorgelbg jorgelbg requested review from osg-grafana and Eve832 and removed request for a team September 13, 2021 15:38
@CLAassistant
Copy link

CLAassistant commented Sep 13, 2021

CLA assistant check
All committers have signed the CLA.

@grafanabot grafanabot added type/docs pr/external This PR is from external contributor labels Sep 13, 2021
Copy link
Contributor

@achatterjee-grafana achatterjee-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achatterjee-grafana achatterjee-grafana added the old backport v8.1.x Mark PR for automatic backport to v8.1.x label Sep 13, 2021
@achatterjee-grafana achatterjee-grafana merged commit ae4900e into grafana:main Sep 13, 2021
grafanabot pushed a commit that referenced this pull request Sep 13, 2021
The current version of the docs contains a broken link to the GCS docs about signed URLs. The link (since it contains an additional `]`) generates a 404 and also slightly breaks the rendering of the link.

(cherry picked from commit ae4900e)
achatterjee-grafana pushed a commit that referenced this pull request Sep 13, 2021
The current version of the docs contains a broken link to the GCS docs about signed URLs. The link (since it contains an additional `]`) generates a 404 and also slightly breaks the rendering of the link.

(cherry picked from commit ae4900e)

Co-authored-by: Jorge Luis Betancourt <jorge-luis.betancourt@trivago.com>
@jorgelbg jorgelbg deleted the patch-1 branch September 17, 2021 13:51
stevepostill pushed a commit to Reveal-International/grafana that referenced this pull request Nov 3, 2021
…-github to revdev

* commit '56aebaac32bd7a82f84a571969b51c62ba54fd6d': (23 commits)
  "Release: Updated versions in package to 8.1.4" (grafana#39273)
  Docs: Update azuread docs to mention about env variables (grafana#39203) (grafana#39265)
  Docs: plugin migration guide 7.0.0 to 8.0.0 (grafana#38911) (grafana#39246)
  Docs: Added "manageAlerts" provisioning option. (grafana#38836) (grafana#39253)
  BarChart: Fix legend and tooltip colors off by 1 after data refresh (grafana#39234) (grafana#39252)
  Update silences.md (grafana#38834) (grafana#39243)
  Explore: Ensure logs volume bar colors match legend colors (grafana#39072) (grafana#39120)
  Graph: make old graph panel thresholds work even if ngalert is enabled  (grafana#38918) (grafana#39233)
  Fix regex to identify / as separator (grafana#39220)
  [v8.1.x] BarChart: fix stale bar values and x axis labels
  Add link to default template (grafana#39106) (grafana#39138)
  Doc: Created a separate topic for AWS authentication  (grafana#39012) (grafana#39160)
  LDAP: Search all DNs for users (grafana#38891) (grafana#39167)
  Docs: Fix broken link to signed GCS URLs docs (grafana#39144) (grafana#39149)
  [v8.1.x] Variables: Fix not updating inside a Panel when the preceding Row uses "Repeat For" (grafana#39141)
  Docs: Improve v8 upgrade notes for SQL data sources (grafana#38792) (grafana#39124)
  Explore: Trace view now shows trace start time in selected timezone (grafana#39054) (grafana#39093)
  Alerting: Fix notification channel migration (grafana#38983) (grafana#39053)
  Annotations: Fixes blank panels for queries with unknown data sources (grafana#39017) (grafana#39034)
  Copy cue.mod and packages/grafana-schema to container workdir (grafana#38998) (grafana#39018)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old backport v8.1.x Mark PR for automatic backport to v8.1.x pr/external This PR is from external contributor type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants