refactor(util/grid): rewrite makegrid() with helper functions #158
+373
−550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes `util.panel.calculateLowestYforPanel()`.
Duologic
force-pushed
the
duologic/refactor_makegrid_1
branch
from
b1835ab to
57a407e
Compare
Duologic
force-pushed
the
duologic/refactor_makegrid_1
branch
from
57a407e to
79fe602
Compare
| "w": 8, | ||
| "x": 0, | ||
| "y": 10 | ||
| "y": 9 |
Contributor
There was a problem hiding this comment.
If this is a refactor, how come your output has changed?
Contributor
Author
There was a problem hiding this comment.
This happens in commit 3, before the refactoring. Commit 2 fixes a few bugs in makeGrid, these fixes change the output. The refactor happens in commit 4.
Only commit 6 is a change of the output that I didn't fix in commit 2, I'm being pragmatic here.
Also see description of the PR.
malcolmholmes
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites
util.grid.makeGrid()to use the helper functions fromutil.panelintroduced in #155, this could serve as an example on how to use these functions to create other grid builders.This PR can be reviewed commit-by-commit, following a proper TDD approach:
makeGrid()(see failing tests)makeGrid()to pass the unit testsmakeGrid(), incorrectly calculating the Y for collapsed row panels