Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Conversation

briangann
Copy link
Collaborator

Description

Sync with upstream changes

santhosh-tekuri and others added 30 commits August 24, 2021 13:50
caching_sha2_password uses cleartext password when
the connection is Unix or sharedmemory protocol.
but sha256_password do not.
* Go 1.17 and MariaDB 10.6 are released

* use `utf8mb4_unicode_ci` instead of `utf8_unicode_ci`

https://mariadb.com/kb/en/changes-improvements-in-mariadb-106/#character-sets

> The utf8 character set (and related collations) is now by default an alias for utf8mb3 rather than the other way around.
there's no need to set conn's readline if CheckConnLiveness is false,
and the ReadTimeout shall work with rawConn.Read inside conncheck.
buffer.fill will do SetReadDeadline if needed
Signed-off-by: cuishuang <imcusg@gmail.com>
Report SQLState in MySQLError to allow library users to distinguish user-defined from client / server errors.
Co-authored-by: LGTM Migrator <lgtm-migrator@users.noreply.github.com>
* bump actions/checkout@v3 and actions/setup-go@v3

* enable cache of actions/setup-go

* Revert "enable cache of actions/setup-go"

I don't know why, but some jobs fail with "Could not get cache folder paths".
This reverts commit 185228e.
* Add go1.20 and mariadb10.11 to the testing matrix

* Use latest upstream actions-setup-mysql which has support for mariadb 10.11

* Update authors file
Signed-off-by: cui fliter <imcusg@gmail.com>
reduces allocations when there is only one param because current calculation is off by 2
Co-authored-by: jypelle <jy@fabriks.eu>
* optimized the execution flow of the TestRowsColumnTypes unit test

* Update driver_test.go

---------

Co-authored-by: 渠磊 <xuyan.wxy@oceanbase.com>
Co-authored-by: Inada Naoki <songofacandy@gmail.com>
…ver#1424)

ColumnTypeScanType() returns []byte, string, or sql.NullString.
It returned sql.RawBytes but it was dangoerous.

Fixes go-sql-driver#1423
evanelias and others added 20 commits May 18, 2023 03:28
Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Support for slashes in database names via url escape codes.
On the other hand, '%' in DSN is now treated as percent-encoding.

Co-authored-by: Brian Hendriks <brian@dolthub.com>
…driver#1309)

It now reports the last inserted ID and affected row count for all statements,
not just the last one. This is useful to execute batches of statements such as
UPDATE with minimal roundtrips.

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Advise to use NewConnector instead of FormatDSN because roundtripping is known to not work well.
See go-sql-driver#1410 (comment)
Run (go 1.18+): go test -fuzz FuzzFormatDSN

Note: invalid host:addr values are currently ignored as they are known
to break (ParseDSN doesn't strictly check address format).
Add more roundtrip checks for ParseDSN/FormatDSN.
Signed-off-by: Achille Roussel <achille.roussel@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Aug 8, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 26 committers have signed the CLA.

✅ cuishuang
✅ briangann
❌ santhosh-tekuri
❌ shogo82148
❌ zjj
❌ moredure
❌ thopos
❌ methane
❌ sjmudd
❌ beautifulentropy
❌ pgporada
❌ lance6716
❌ EPuncker
❌ jypelle
❌ frozenbonito
❌ evanelias
❌ wayyoungboy
❌ testwill
❌ dolmen
❌ mherr-google
❌ uji
❌ achille-roussel
❌ Daemonxiao
❌ lgtm-com[bot]
❌ Netzer7
❌ i7a7467
You have signed the CLA already but the status is still pending? Let us recheck it.

case "true":
cfg.TLS = &tls.Config{}
case "skip-verify":
cfg.TLS = &tls.Config{InsecureSkipVerify: true}

Check failure

Code scanning / CodeQL

Disabled TLS certificate check

InsecureSkipVerify should not be used in production code.
case "skip-verify":
cfg.TLS = &tls.Config{InsecureSkipVerify: true}
case "preferred":
cfg.TLS = &tls.Config{InsecureSkipVerify: true}

Check failure

Code scanning / CodeQL

Disabled TLS certificate check

InsecureSkipVerify should not be used in production code.
@briangann briangann merged commit 4e2fb08 into master Aug 8, 2023
@briangann briangann deleted the 20230807_sync_upstream branch August 8, 2023 22:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.