Chore: remove drone and move to github action to release a docker image#255
Merged
Chore: remove drone and move to github action to release a docker image#255
Conversation
academo
requested review from
Ukochka,
oshirohugo,
wbrowne and
xnyo
and removed request for
a team
academo
commented
Sep 17, 2024
| version: latest | ||
| args: release --clean | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Collaborator
Author
There was a problem hiding this comment.
moving away from this token which is most likely expired.
academo
commented
Sep 17, 2024
|
|
||
| - name: Build and test Docker container | ||
| uses: docker/build-push-action@v6 | ||
| - id: push-to-dockerhub |
Collaborator
Author
There was a problem hiding this comment.
for consistency I am using the same action here with push: false for testing.
s4kh
approved these changes
Sep 17, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes drone file and moves all the docker release logic inside github workflows