chore(ruby): keep only ruby in this repo#1
Conversation
korniltsev-grafanista
force-pushed
the
kk/import2
branch
from
7261201 to
050fc28
Compare
korniltsev-grafanista
force-pushed
the
kk/import2
branch
from
050fc28 to
d0d836b
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 050fc284e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
korniltsev-grafanista
force-pushed
the
kk/import2
branch
2 times, most recently
from
699024d to
fd9614c
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd9614cf8e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
korniltsev-grafanista
force-pushed
the
kk/import2
branch
2 times, most recently
from
b7b229e to
ccce230
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccce2305e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| s.files = [ | ||
| "Gemfile", | ||
| "Gemfile.lock", | ||
| "LICENSE", | ||
| "README.md", |
There was a problem hiding this comment.
The s.files list now omits ext/rbspy/Rakefile, ext/rbspy/Cargo.toml, and Rust sources, but the gem still declares s.extensions = ['ext/rbspy/extconf.rb']. On source installs (for any platform without a prebuilt native gem), extconf.rb invokes Rake and immediately fails because the packaged gem does not contain the required extension files, so users cannot install from source. This regression is user-facing because the release workflow still publishes a source gem artifact.
Useful? React with 👍 / 👎.
korniltsev-grafanista
force-pushed
the
kk/import2
branch
from
ccce230 to
917fe1d
Compare
Python, Ruby, and kindasafe have been extracted to their own repositories: - grafana/pyroscope-python (grafana/pyroscope-python#1) - grafana/pyroscope-ruby (grafana/pyroscope-ruby#1) This leaves pyroscope-rs as a pure Rust profiling library crate. Removed: - `pyroscope_ffi/` — all Python and Ruby FFI source code - `kit/` — kindasafe and kindasafe_init crates - `docker/` — wheel, musllinux, and gem Dockerfiles - `ci/` — version bump, tag check, spy version check scripts - All Python/Ruby/kindasafe CI workflows - `pyproject.toml`, `setup.py`, `MANIFEST.in`, `ffi.mk` - `[workspace]` and `[workspace.dependencies]` — inlined deps, no more workspace members Simplified: - `release.yml` — only `lib-*` tags, uses `make check/lib-tag-version` - `ci-rust.yml` — single package, no matrix; removed kindasafe-versions check and macOS test job - `Makefile` — removed FFI targets, added `check/lib-tag-version` Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 917fe1d6f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| s.files = [ | ||
| "Gemfile", | ||
| "Gemfile.lock", | ||
| "LICENSE", |
There was a problem hiding this comment.
The new gemspec’s s.files list no longer includes ext/rbspy/*, but source:gem (used in the release workflow) packages that list with s.extensions still enabled. That means the published source gem will be missing ext/rbspy/extconf.rb and Rust sources, so installation from source (e.g., on platforms without a prebuilt binary gem) will fail during native extension setup.
Useful? React with 👍 / 👎.
2 participants
No description provided.