ci: add release-please configuration#14
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
- Add package-name: pyroscope so ruby type finds lib/pyroscope/version.rb - Use explicit generic type for extra-files to fix Cargo.toml version updates Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
The ruby release type looks for lib/ruby/version.rb (using component name) instead of lib/pyroscope/version.rb. Adding it as a generic extra-file with the x-release-please-version marker ensures it gets updated. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54b8f29f36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uses: googleapis/release-please-action@16a9c90856f42705d54a6fda1823352bdc62cf38 # v4 | ||
| with: | ||
| config-file: release-please-config.json | ||
| manifest-file: .release-please-manifest.json |
There was a problem hiding this comment.
This step omits the token input, so googleapis/release-please-action falls back to GITHUB_TOKEN; per the action’s docs, tags/PRs created with that token do not trigger other workflows. In this repo the new config sets skip-github-release: true, so the release handoff depends on the ruby-* tag push triggering .github/workflows/release.yml; with the default token that tag push will not fan out, and the gem release pipeline will stop after the release PR is merged.
Useful? React with 👍 / 👎.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7292af9ad6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,3 +1,7 @@ | |||
| module Pyroscope | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
lib/pyroscope/version.rb now contains unresolved conflict markers, which makes the file invalid Ruby and raises a SyntaxError as soon as the version file is loaded. Any runtime path that requires this file (including gem initialization) will fail immediately, so the release produced from this commit is unusable until the conflict markers are removed.
Useful? React with 👍 / 👎.
| @@ -1,6 +1,10 @@ | |||
| [package] | |||
| name = "ffiruby" | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
ext/rbspy/Cargo.toml includes unresolved conflict markers, so Cargo cannot parse the manifest (key with no value, expected '='). This breaks Rust-based tasks in this repo (e.g., the new lockfile update step and any native extension build/test path using this manifest) until the markers are resolved.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e2c268c0a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [package] | ||
| name = "ffiruby" | ||
| version = "1.0.1" | ||
| version = "1.0.1" # x-release-please-version |
There was a problem hiding this comment.
Adding # x-release-please-version to the version line makes the existing make check/tag-version parser misread CARGO_VERSION: sed in Makefile:40 replaces only the matched prefix and leaves the trailing comment, producing 1.0.1 # x-release-please-version instead of 1.0.1. The release workflow runs this check in .github/workflows/release.yml (“Verify tag matches package version”), so every ruby-* tag release will fail before artifacts are built.
Useful? React with 👍 / 👎.
2 participants
Adds release-please to automate version bumps, changelog generation, and tag creation.
ruby(natively updateslib/pyroscope/version.rb)ruby→ tags:ruby-X.Y.Z(no v prefix)ext/rbspy/Cargo.tomlvia generic markerskip-github-release: true— only creates tags, existingrelease.ymlhandles draft GitHub releasesupdate-lockfilejob to keepCargo.lockin sync forcargo test --lockedbootstrap-shaset to current HEAD to avoid huge first changelog