Skip to content

Conversation

@korniltsev
Copy link
Contributor

@korniltsev korniltsev commented Dec 11, 2024

@korniltsev korniltsev requested a review from a team as a code owner December 11, 2024 09:24
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The hard part remains the testing if it still compile/runs/sends profiles. When I ran this locally I mostly ran the one tracing example that contained all of the SDK, but we are breaking that up 😂

make tools/update_examples_pr
fi
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if this is the right token, this does something very similar:

GITHUB_TOKEN: ${{ secrets.BOT_GITHUB_TOKEN }}

@aleks-p
Copy link
Contributor

aleks-p commented Dec 11, 2024

The hard part remains the testing if it still compile/runs/sends profiles. When I ran this locally I mostly ran the one tracing example that contained all of the SDK, but we are breaking that up 😂

Technically we can still maintain a setup with all SDKs together. I don't think it is the best example to show users, but we could convert it to an integration test of some sort (outside of this PR).

@korniltsev
Copy link
Contributor Author

compile/runs/sends profiles

It would be nice if we could automate this somehow

@korniltsev korniltsev merged commit 06d88ca into grafana:main Dec 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants