chore(examples): update Go pprof migration example #3768
Conversation
kolesnikovae
force-pushed
the
chore/update-go-pprof-migration-example
branch
from
4b3b2b9 to
d32764e
Compare
| if err != nil { | ||
| log.Fatalf("Error starting profiler: %v", err) | ||
| } | ||
| defer profiler.Stop() |
There was a problem hiding this comment.
We typically don't include this in our examples, but I believe it's something we should address. The last bit of information we usually omit can provide valuable insights. OTOH, we don't say anything about it in the README and in the source PR (which I can't update).
In this specific example this is required as the app usually exits before any profiles are sent. Alternatively, we could simply hang, but the mystery wouldn't be solved then!
There was a problem hiding this comment.
Would it make sense to update it as well in our SDK docs and README? 🤔
| if err != nil { | ||
| log.Fatalf("Error starting profiler: %v", err) | ||
| } | ||
| defer profiler.Stop() |
There was a problem hiding this comment.
Would it make sense to update it as well in our SDK docs and README? 🤔
Done! |
2 participants
I made slight modifications to the example code to fix the issue with premature exit. The README is well written; I only added a link to the docs and included some notes about the runtime functions we call.