Issue 61: Updated endpoint to return list of all clusters #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaelleC
requested review from
andresmgot,
iwysiu and
vickyyyyyyy
and removed request for
a team
andresmgot
reviewed
Mar 4, 2022
Contributor
andresmgot
left a comment
andresmgot
left a comment
There was a problem hiding this comment.
Nice! Some minor comments here.
pkg/redshift/api/api.go
Outdated
| res := []models.RedshiftCluster{} | ||
| for _, r := range out.Clusters { | ||
| res = append(res, models.RedshiftCluster{ | ||
| ClusterIdentifier: *r.ClusterIdentifier, |
Contributor
There was a problem hiding this comment.
I'm afraid we still need the nil point checks 😅
pkg/redshift/api/api_test.go
Outdated
| expectedCluster *models.RedshiftCluster | ||
| c *API | ||
| desc string | ||
| clusterId string |
Contributor
There was a problem hiding this comment.
you can remove now the clusterId input
pkg/redshift/routes/routes.go
Outdated
Comment on lines
37
to
42
| reqBody, err := routes.ParseBody(req.Body) | ||
| if err != nil { | ||
| rw.WriteHeader(http.StatusBadRequest) | ||
| routes.Write(rw, []byte(err.Error())) | ||
| return | ||
| } |
Contributor
There was a problem hiding this comment.
you don't need now to parse the body, it should be a GET request (similar to the Secrets function)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend work (second iteration) for #61
First iteration merged: #121
Description
To be more user friendly and avoid typos, we want to change Redshift's UI to use a dropdown (if permissions allow) to select a clusterID.
This PR updates the
clusterendpoint toclustersthat return the list of all clustersA next PR #127 will use it to display the dropdown and update the description on the datasource card
Test coverage