Init #1
Draft
Init #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r, reran all codegen
…lugins that aren't used
…under consideration would put the node over utilization
terraboops
reviewed
Sep 26, 2025
Comment on lines
+37
to
+52
| // app.WithPlugin(capacityscheduling.Name, capacityscheduling.New), | ||
| // app.WithPlugin(coscheduling.Name, coscheduling.New), | ||
| // app.WithPlugin(loadvariationriskbalancing.Name, loadvariationriskbalancing.New), | ||
| // app.WithPlugin(networkoverhead.Name, networkoverhead.New), | ||
| // app.WithPlugin(topologicalsort.Name, topologicalsort.New), | ||
| // app.WithPlugin(noderesources.AllocatableName, noderesources.NewAllocatable), | ||
| // app.WithPlugin(noderesourcetopology.Name, noderesourcetopology.New), | ||
| // app.WithPlugin(preemptiontoleration.Name, preemptiontoleration.New), | ||
| // app.WithPlugin(targetloadpacking.Name, targetloadpacking.New), | ||
| // app.WithPlugin(lowriskovercommitment.Name, lowriskovercommitment.New), | ||
| // app.WithPlugin(sysched.Name, sysched.New), | ||
| // app.WithPlugin(peaks.Name, peaks.New), | ||
| // // Sample plugins below. | ||
| // // app.WithPlugin(crossnodepreemption.Name, crossnodepreemption.New), | ||
| // app.WithPlugin(podstate.Name, podstate.New), | ||
| // app.WithPlugin(qos.Name, qos.New), |
There was a problem hiding this comment.
Why are we commenting these out?
If we don't need them, should we just delete?
terraboops
approved these changes
Sep 26, 2025
terraboops
left a comment
terraboops
left a comment
There was a problem hiding this comment.
Looks good to me.
Are you sure we should be committing the generated files? I have seen both approaches in Kubernetes controller land and I'm not sure what the tradeoffs are, but generally speaking I find it's easier to .gitignore generated files.
Approved regardless; we can cleanup generated files later if we decide to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init