This repository was archived by the owner on Jan 30, 2025. It is now read-only.
Fix incorrect keyboard key code on down and up #807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Key cannot be empty value, so this check isn't needed. 2. Since we've now defined the Code in the original us keyboard definition file, we can safely copy the src Code to the new local keyDef Fixes: #806
The code for a key should not be a (for example), but something like KeyA. This test ensures that we're sticking to this behaviour.
This test goes through all the known key values on the keyboard. Note that the key value can associate to more than one code. Resolves: #807 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that was found while working with a Dockerized browser and running the
fillform.jstest. It turns out that we were setting the wrong code onDispatchKeyEventCDP command.This was verified by taking a look at how the KeyDescription was being built and from there it was clear we were using the wrong code.
The change was tested with
fillform.jsafter the fix and we're no longer seeing the following warnings:Fixes: #806