-
Notifications
You must be signed in to change notification settings - Fork 74
Update Dashboards and Docker Compose setup #148
Conversation
codebien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort @ppcano! 🙇
I added some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When I open the dashboard the first time, it should keep open the Performance Overview section. It looks better to me.
- Why the default quantile is 99? Why do we call it here quantile and p9x in the other? We should pick only one name to have a consistent glossary.
- The
AnalyzeMetricon top creates confusion, it applies only to one chart and not to all of them as you expect from something on top. Also, in the end, having a panel for doing what the Explore functionality in Grafana already does seems not optimal to me. For these two reasons, I'm for us dropping completely the Analyze panel. - I think HTTP section should stay before Checks section.
- I don't know if there is a way to do it, but if I select a
testIDthen I would like to get the time range that centers the test and not use a relative time range. - The Adhoc filters adds confusion, it pulls series not relevant for the k6 context. We should drop it, because if the user needs to add custom queries then the Explorer is the correct tool.
✅ All the sections are open now.
The format of both options cannot be the same.
Although the situation is not ideal, exposing this info to the end-user could guide them to learn how this output and the k6 metric format work. The default for NH is 0.99 because is the default of For consistency, I have now renamed the variable name.
✅ ok - I agree is redundant and adds an unnecessary overhead. My intention here was to "guide" users how to query k6 metrics. Wdyt about adding an informative panel like:
✅
This option is not available.
Agree, it adds confusion. To improve this, I have opened a feature request in the grafana repo. I'd preserve the AdhocFilter because:
|
codebien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙇 🎉
oleiade
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 😎 Overall I find this to be an improvement indeed 👍🏻
I've also spotted some small UI inconsistencies: some lines are full / some are dotted, some graphs have a "filling" / some don't. But I assumed this was made on purpose.
I have however spotted that some graphs stayed empty ("no data") in the native histograms dashboard (they have data in the normal one). Is this expected?
|
@oleiade, thanks for sharing!
Good that you have mentioned them. I know there are still a few inconsistencies like "filling" charts. I'll give a last review to fix them. Dotted lines are for req_per_second metrics.
Yes. I guess the reason is that for NH, the This is why we need two different dashboards. This is documented on the docs but I am not sure if it is very clear. As part of the changes associated to new dashboard, I'll try to update that part of the docs. |




Update the existing test result dashboard, it is now called
k6 Prometheus.It also creates a new similar dashboard,
k6 Prometheus - Native Histograms, to be used when storing trend metrics in native histograms.These dashboards are an advancement from the existing one and #142. A big thanks to @jwcastillo for their exceptional work and contributions.
Docker compose changes
Other changes
k6 Prometheus - Native Histograms
Dynamic variables to configure the dashboard queries:
testidtag is presentk6 Prometheus
This dashboard is similar than the previous one. Instead of
Quantile, it hasTrend Metrics Queryto select the Stat depending on the values from theK6_PROMETHEUS_RW_TREND_STATSoption.