Skip to content

grafbase-postgres: lookup fields should not have a non-null wrapper #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2025
Merged

grafbase-postgres: lookup fields should not have a non-null wrapper #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions cli/postgres/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

All notable changes to the Grafbase PostgreSQL CLI tool will be documented in this file.

## [0.3.9] - 2025-09-05

- Generate `@lookup` fields without non-null wrappers, since per the composite schemas spec, lookup fields should be nullable.

## [0.3.7] - 2025-05-22

### Added
Expand Down
2 changes: 1 addition & 1 deletion cli/postgres/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "grafbase-postgres"
version = "0.3.8"
version = "0.3.9"
edition = "2024"
license = "Apache-2.0"

Expand Down
2 changes: 1 addition & 1 deletion crates/postgres-introspection/src/render/query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ pub fn render<'a>(
None => format!("{}_lookup", table.client_name()).to_camel_case(),
};

let mut field = Field::new(field_name, format!("[{}]!", table.client_name()));
let mut field = Field::new(field_name, format!("[{}]", table.client_name()));

field.set_description(format!(
"Lookup multiple {} for subgraph joins",
Expand Down
Loading
Loading