Customizable #2
Open
Customizable #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…string with associated tests
added 2 commits
December 8, 2021 09:01
Query.eq with a null value does not do as expected; use the more specific Query.isNull restriction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates are as per @jameskleeh request. The original LogicalDelete trait has been mostly left alone so as not to cause issues for the client that we originally wrote this for, this original trait should be viewed as the default and uses primitive boolean types and determines if a recored is logically deleted based on a true / false value. I have added a base trait to the plugin to encapsulate base
GormEntityfunctions and 3 additional traits ofBooleanLogicalDelete,DateLogicalDelete, andStringLogicalDeletewhich allow a plugin user to determine more specifically what they want their deleted field to be, if the deleted field is null, it is not deleted, if the deleted field contains a Boolean, Date, or string value as per the implemented trait is is logically deleted. This should also be user extensible, as in if a user wants to write aMyCustomObjectDelete<D>they should be able to do so following that the value null means not deleted and if its NOT NULL, then it is logically deleted.