This repository was archived by the owner on Mar 10, 2025. It is now read-only.
Upgrade to graphql-java 16.1 #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And a minimum of a queryType is required for the schema to be generated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest breaking changes from 14.0 that are relevant to this project include:
The assertion that a schema must have a queryType. This essentially breaks our ability to do
operations.query.enabled falsewhen there are no other query operations present. This felt a little strange to me and I asked on their spectrum why this is required, as it seems perfectly legit to have a write-only API.Update: I guess it's part of the spec after all
The assertion that all object types must have fields defined. This is especially relevant for some input types since they would not have at a minimum an
idproperty like object output types do. Per the GraphQL spec, the very first rule for adhering to object type validation is:...so this one makes a bit more sense.