Fix querying properties of embedded objects

grails-datastore-gorm-mongodb/build.gradle

@@ -14,6 +14,7 @@ dependencies {
     compileOnly "javax.servlet:javax.servlet-api:$servletApiVersion"
 
     testImplementation "org.grails:grails-datastore-gorm-tck:$datastoreVersion"
+    testImplementation "org.grails:grails-gorm-testing-support:${testingSupportVersion}"
     testImplementation "org.hibernate:hibernate-validator:$hibernateValidatorVersion"
     testImplementation "org.grails:grails-datastore-gorm-support:$datastoreVersion", {
         exclude group: "org.grails", module:"grails-datastore-gorm-hibernate-core"

grails-datastore-gorm-mongodb/src/main/groovy/org/grails/datastore/mapping/mongo/config/MongoMappingContext.java

@@ -375,16 +375,23 @@ public PersistentEntity createEmbeddedEntity(Class type) {
 
     class DocumentEmbeddedPersistentEntity extends EmbeddedPersistentEntity {
 
-        private DocumentCollectionMapping classMapping ;
+        private DocumentCollectionMapping classMapping;
+
         public DocumentEmbeddedPersistentEntity(Class type, MappingContext ctx) {
             super(type, ctx);
             classMapping = new DocumentCollectionMapping(this, ctx);
         }
 
+        @Override
+        public boolean isIdentityName(String propertyName) {
+            return false;
+        }
+
         @Override
         public ClassMapping getMapping() {
             return classMapping;
         }
+
         public class DocumentCollectionMapping extends AbstractClassMapping<Collection> {
             private Collection mappedForm;
 

grails-datastore-gorm-mongodb/src/test/groovy/org/grails/datastore/gorm/mongo/EmbeddedWhereClauseSpec.groovy

@@ -0,0 +1,56 @@
+package org.grails.datastore.gorm.mongo
+
+import grails.gorm.services.Service
+import grails.gorm.services.Where
+import grails.gorm.tests.GormDatastoreSpec
+import grails.persistence.Entity
+import grails.testing.services.ServiceUnitTest
+
+import javax.persistence.Embeddable
+
+class EmbeddedWhereClauseSpec extends GormDatastoreSpec {
+
+    void "Can construct data service where clause on embedded object"() {
+        given:"An object with an embedded field on it"
+        def attribute = new PersonAttribute(contexts: [new AttributeContext(neighborhoodId: '1234')])
+        attribute.save()
+        session.flush()
+        session.clear()
+        def service = session.datastore.getService(PersonAttributeDataService)
+
+        when:"We query using the autogenerated where clause"
+        def response = service.findByNeighborhoodId('1234')
+
+        then:"The association is valid"
+        response.size() == 1
+        response.first().contexts.first().neighborhoodId == '1234'
+    }
+
+    @Override
+    List getDomainClasses() {
+        [PersonAttribute]
+    }
+}
+
+@Entity
+class PersonAttribute {
+    String id
+    List<AttributeContext> contexts = []
+    static embedded = ['contexts']
+}
+
+@Embeddable
+class AttributeContext {
+
+    String id
+    String neighborhoodId
+
+    static belongsTo = [attribute: PersonAttribute]
+
+}
+
+@Service(PersonAttribute)
+interface PersonAttributeDataService {
+    @Where({ contexts { neighborhoodId == neighborhoodId } })
+    List<PersonAttribute> findByNeighborhoodId(String neighborhoodId)
+}