Skip to content

Conversation

@phated
Copy link
Member

@phated phated commented Aug 20, 2022

When trying to install the dependencies on a Mac M1, I found that hexo-renderer-scss didn't install on a default setup. This switches the unmaintained plugin for a (likely just as unmaintained) plugin that uses dartsass.

I don't actually know where we use scss so I'm looking to @ospencer to double check the styling.

I also updated vscode-textmate as I need the newest version for the playgound.

To cap it all off, I generated the lockfile with a newer npm so we have lockfile v2.

@phated phated requested a review from ospencer August 20, 2022 03:39
@netlify
Copy link

netlify bot commented Aug 20, 2022

Deploy preview ready! 🌾

Name Link
🔨 Latest commit e20403b
🔍 Latest deploy log https://app.netlify.com/sites/grain-lang/deploys/6300576cf3f220000934575d
😎 Deploy Preview https://deploy-preview-311--grain-lang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling still looks good!

@phated phated merged commit 0bd25a2 into master Aug 22, 2022
@phated phated deleted the phated/hexo-dartsass branch August 22, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants