fix: Don't include binaryen submodules so Windows builds with opam #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
approved these changes
Nov 6, 2025
ospencer
added a commit
that referenced
this pull request
Nov 6, 2025
ospencer
added a commit
that referenced
this pull request
Nov 6, 2025
ospencer
added a commit
that referenced
this pull request
Nov 6, 2025
) fix: Don't include binaryen submodules so Windows builds with opam (#138)
ospencer
added a commit
that referenced
this pull request
Nov 6, 2025
) fix: Don't include binaryen submodules so Windows builds with opam (#138)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows builds of binaryen.ml are failing because paths included in binaryen submodules used for testing end up being too long because of the way opam sets up its directory structure. This PR makes no code changes; it only changes how releases are prepared by not including the submodules. This build with no submodules is tested in CI in both the esy and opam workflows.
An example of the failure can be found in this run: https://github.com/grain-lang/binaryen.ml/actions/runs/19006995118/job/54401493486
I published a version of libbinaryen to my opam fork which does not include the submodules, and you can see it passing in binaryen.ml here: https://github.com/grain-lang/binaryen.ml/actions/runs/19123129929/job/54647560908?pr=208