Skip to content

Feature trex #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 30, 2021
Merged

Feature trex #23

merged 11 commits into from
Jan 30, 2021

Conversation

@instanceofMA
Copy link
Contributor

@instanceofMA instanceofMA commented Jan 30, 2021 •
edited
Loading

This feature introduces the following changes:

  • Added a dynamic type Var.
  • Async functions now accept callback of any type not only void(*)(JSONObject).
  • Message queuing when the device is not connected with Grandeur is improved.

moizhusnain and others added 10 commits January 24, 2021 06:36
@moizhusnain
Now follows new api scheme
6682ae8
@moizhusnain
Implemented callback with template
fb9f7c5
@moizhusnain
New callback implmentation
d5d57e1 
The event handlers of data can be now type specific
@moizhusnain
Fixed callback and queue
17bd3d2 
Callback is now based on Var, plus overloading is just on const char*
We aren't handling types in callback for now
Fixed queue, had to had another datastructure
@moizhusnain
Fixed backward compatibility issue
ecc3c03
@moizhusnain
Now handling type casting in callback
e76fb1f 
The callback can be typed or can be var
In case of var, it will receive update without casting
or otherwise the data will be casted or error will be returned
@moizhusnain
Now the sub queues every message
a9e7dc5 
It will help us in restoring all subs when required
also added unsub, which automatically deletes subs from queue
@instanceofMA
Readme.md is being updated.
bae566d
@instanceofMA
Readme.md is updated
cdf7928
@instanceofMA
Readme.md is updated
11cefe4
@instanceofMA instanceofMA added the enhancement New feature or request label Jan 30, 2021
@moizhusnain
Reverted the url to api.grandeur.tech
b61beea 
The url in macro was trex.dev.grandeur.tech so i got to revert t.
moizhusnain
moizhusnain approved these changes Jan 30, 2021
View reviewed changes
Copy link
Member

@moizhusnain moizhusnain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@moizhusnain moizhusnain merged commit 6d77d32 into master Jan 30, 2021
@moizhusnain
Copy link
Member

moizhusnain commented Jan 30, 2021

Created a release.

@moizhusnain moizhusnain deleted the feature-trex branch January 30, 2021 21:40
@moizhusnain moizhusnain restored the feature-trex branch January 30, 2021 21:40
@moizhusnain moizhusnain deleted the feature-trex branch January 30, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moizhusnain moizhusnain moizhusnain approved these changes

Assignees

@moizhusnain moizhusnain

@instanceofMA instanceofMA

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@instanceofMA @moizhusnain