Skip to content

Correct set/get_saved_par order #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

Correct set/get_saved_par order #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25907d1
save current pars before restoring old ones
grantmcdermott Sep 18, 2025
6906d1e
add test
grantmcdermott Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions R/tinyplot.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,15 +659,6 @@ tinyplot.default = function(
}
}

# catch for adding to existing facet plot
if (!is.null(facet) && add) {
recordGraphics(
par(get_saved_par(when = "after")),
list = list(),
env = getNamespace('tinyplot')
)
}

# Save current graphical parameters
opar = par(no.readonly = TRUE)
if (restore.par || !is.null(facet)) {
Expand All @@ -678,6 +669,15 @@ tinyplot.default = function(
}
set_saved_par(when = "before", opar)

# Catch for adding to existing facet plot
if (!is.null(facet) && add) {
recordGraphics(
par(get_saved_par(when = "after")),
list = list(),
env = getNamespace('tinyplot')
)
}

# Ephemeral theme
if (!is.null(theme)) {
# browser()
Expand Down
Loading