Skip to content

Popart bert data path fix #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2022
Merged

Popart bert data path fix #55

merged 1 commit into from
Oct 13, 2022

Conversation

@hiteshk-gc
Copy link
Contributor

@hiteshk-gc hiteshk-gc commented Oct 12, 2022

Fixes the input_files field in the packed/tiny 512 config to be consistent with all the other configs of this type.

Found by @evawGraphcore when investigating https://graphcore.zendesk.com/agent/tickets/4210

@hiteshk-gc hiteshk-gc added the bug Something isn't working label Oct 12, 2022
@hiteshk-gc hiteshk-gc requested a review from a team October 12, 2022 16:04
@hiteshk-gc hiteshk-gc self-assigned this Oct 12, 2022
@hiteshk-gc hiteshk-gc requested a review from a team as a code owner October 12, 2022 16:04
@hiteshk-gc hiteshk-gc requested review from kundaMwiza and removed request for a team October 12, 2022 16:04
@RouxJohannes RouxJohannes merged commit 86ccafd into master Oct 13, 2022
@RouxJohannes RouxJohannes deleted the data_path_fix branch October 13, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RouxJohannes RouxJohannes RouxJohannes approved these changes

@kundaMwiza kundaMwiza Awaiting requested review from kundaMwiza kundaMwiza is a code owner automatically assigned from graphcore/applications

Assignees

@hiteshk-gc hiteshk-gc

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hiteshk-gc @RouxJohannes