-
Notifications
You must be signed in to change notification settings - Fork 15
feat(proxyd): support envsubst for config #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughBumps proxyd chart to 0.7.0. Introduces envsubst-driven config templating via an initContainer, new environment/ulimit options, and tightened security. Adds Grafana Operator dashboard templating and overhauls the bundled Grafana dashboard. Expands values and README to document new fields and behavior. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as User (Helm install/upgrade)
participant H as Helm (proxyd chart)
participant K as Kubernetes
participant I as InitContainer (envsubst)
participant P as Proxyd Container
U->>H: helm upgrade --install
H->>K: Create Deployment (envsubst enabled?)
alt envsubst enabled
K-->>I: Start initContainer render-config
I->>I: Validate TEMPLATE_PATH and REQUIRED_VARS
I->>I: Render /config/config.toml via envsubst
I-->>K: Exit 0 on success
K-->>P: Start main container
P->>P: Apply ulimit (nofile)
P->>P: exec proxyd /config/config.toml
else envsubst disabled
K-->>P: Start main container with ConfigMap-mounted config
P->>P: exec proxyd /config/config.toml
end
sequenceDiagram
autonumber
participant H as Helm (proxyd chart)
participant K as Kubernetes
participant GO as Grafana Operator
participant G as Grafana
H->>K: Create GrafanaDashboard CRs (if enabled)
K-->>GO: Reconcile GrafanaDashboard
GO->>G: Provision/Update dashboards from JSON payloads
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (7)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
New Features
Documentation
Chores