-
Notifications
You must be signed in to change notification settings - Fork 4
feat(polygon): adding bor api to erigon #1298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request updates the Erigon configuration templates for both Amoy and Mainnet deployments by modifying the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
polygon/values/amoy/erigon.yaml.gotmpl (1)
1-22: Consider documenting the purpose of the bor API endpoint.While the change itself is straightforward, it might be helpful to include comments explaining what the
borAPI provides and why it's being added.- --bor.heimdall=http://heimdall-ha-svc:1317 - - --http.api=eth,debug,net,trace,bor + - --http.api=eth,debug,net,trace,bor # Added bor API for Polygon-specific operations
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
polygon/values/amoy/erigon.yaml.gotmpl(1 hunks)polygon/values/mainnet/erigon.yaml.gotmpl(1 hunks)
🔇 Additional comments (2)
polygon/values/mainnet/erigon.yaml.gotmpl (1)
7-7: Properly adds the bor API endpoint.This change appropriately adds the
borAPI to the list of HTTP API endpoints that Erigon will expose, making it consistent with the Amoy configuration.Given that this file also has
--bor.heimdallconfiguration on line 6, adding the bor API is a logical extension to enable clients to interact with the Bor-specific functionality.polygon/values/amoy/erigon.yaml.gotmpl (1)
7-7: Properly adds the bor API endpoint.This change appropriately adds the
borAPI to the list of HTTP API endpoints that Erigon will expose, making it consistent with the Mainnet configuration.Given that this file also has
--bor.heimdallconfiguration on line 6, adding the bor API is a logical extension to enable clients to interact with the Bor-specific functionality.
Summary by CodeRabbit