-
Notifications
You must be signed in to change notification settings - Fork 157
Token API: updated FAQ wording, updated DEX section, adjusted upgrade v1 notes #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token API: updated FAQ wording, updated DEX section, adjusted upgrade v1 notes #1046
Conversation
| ### How do I retrieve the spam status for a collection? | ||
|
|
||
| See the spam_status field on the [`/v1/evm/nft/collections/{contract}`](/token-api/evm-nfts/collections/) endpoint. | ||
| See the spam_status field on the [`/v1/evm/nft/collections/{contract}`](/token-api/evm/get-nft-collections-evm-by-contract/) endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL doesn't seem to be valid? https://thegraph.com/docs/en/token-api/evm/get-nft-collections-evm-by-contract/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous one, on the other hand, is: https://thegraph.com/docs/en/token-api/evm-nfts/collections/
But it doesn't match the endpoint's URL perfectly: contract is a query param, not a path param. I think the right fix here is:
| See the spam_status field on the [`/v1/evm/nft/collections/{contract}`](/token-api/evm/get-nft-collections-evm-by-contract/) endpoint. | |
| See the spam_status field on the [`/v1/evm/nft/collections`](/token-api/evm-nfts/collections/) endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea just noticed that, cross checking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed, it's https://thegraph.com/docs/en/token-api/evm-nfts/collections/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm asking more info about the query param you mentioned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{contract} will be removed
benface
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me except the comment I left above.
benface
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
-Added tron on Which blockchains are supported by the Token API? section
-On Why do I only see 10 results? How can I get more data? section, changed limit from 50 to 10, also modified context
-Removed What exchanges does the Token API use for token prices? section
-Quick start page on the Prerequisite section, sign up link redirects to https://thegraph.market/plans/token-api/2025/ (was https://thegraph.market/)
-Upgrade to v1 section changed Backward compatibility to past tense (Migration Notes:)