Node v14 support

[matthewlilley]

It seems that we're locked into depedencies which will only work on Node v16. Unfortuantely even AWS isn't supporting v16 yet which means we're blocked from using this. I have done some trial and error to find v14 compatbile options, but unable to find any compatible combination so far.

[matthewlilley]

`../../node_modules/.pnpm/fast-json-stringify@1.21.0/node_modules/fast-json-stringify/index.js
Module not found: Can't resolve 'long' in '/home/feedme/interface/node_modules/.pnpm/fast-json-stringify@1.21.0/node_modules/fast-json-stringify'

Import trace for requested module:
../../node_modules/.pnpm/graphql-jit@0.7.3/node_modules/graphql-jit/dist/execution.js
../../node_modules/.pnpm/graphql-jit@0.7.3/node_modules/graphql-jit/dist/index.js
../../node_modules/.pnpm/@graphql-mesh+utils@0.27.9/node_modules/@graphql-mesh/utils/index.mjs
./.graphclient/index.ts
./pages/index.tsx

../../node_modules/.pnpm/fast-json-stringify@1.21.0/node_modules/fast-json-stringify/index.js
Module not found: Can't resolve 'uglify-es' in '/home/feedme/interface/node_modules/.pnpm/fast-json-stringify@1.21.0/node_modules/fast-json-stringify'

Import trace for requested module:
../../node_modules/.pnpm/graphql-jit@0.7.3/node_modules/graphql-jit/dist/execution.js
../../node_modules/.pnpm/graphql-jit@0.7.3/node_modules/graphql-jit/dist/index.js
../../node_modules/.pnpm/@graphql-mesh+utils@0.27.9/node_modules/@graphql-mesh/utils/index.mjs
./.graphclient/index.ts
./pages/index.tsx

../../node_modules/.pnpm/fast-json-stringify@1.21.0/node_modules/fast-json-stringify/index.js
Module not found: Can't resolve 'uglify-es/package.json' in '/home/feedme/interface/node_modules/.pnpm/fast-json-stringify@1.21.0/node_modules/fast-json-stringify'

Import trace for requested module:
../../node_modules/.pnpm/graphql-jit@0.7.3/node_modules/graphql-jit/dist/execution.js
../../node_modules/.pnpm/graphql-jit@0.7.3/node_modules/graphql-jit/dist/index.js
../../node_modules/.pnpm/@graphql-mesh+utils@0.27.9/node_modules/@graphql-mesh/utils/index.mjs
./.graphclient/index.ts
./pages/index.tsx

./.graphclient/index.ts
Attempted import error: 'gql' is not exported from '@graphql-mesh/utils' (imported as 'gql').

Import trace for requested module:
./pages/index.tsx

../../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js
Module not found: Can't resolve 'encoding' in '/home/feedme/interface/node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib'

Import trace for requested module:
../../node_modules/.pnpm/cross-undici-fetch@0.1.25/node_modules/cross-undici-fetch/dist/node-ponyfill.js
../../node_modules/.pnpm/@graphql-mesh+utils@0.27.9/node_modules/@graphql-mesh/utils/index.mjs
./.graphclient/index.ts
./pages/index.tsx

../../node_modules/.pnpm/ws@7.5.7/node_modules/ws/lib/buffer-util.js
Module not found: Can't resolve 'bufferutil' in '/home/feedme/interface/node_modules/.pnpm/ws@7.5.7/node_modules/ws/lib'

Import trace for requested module:
../../node_modules/.pnpm/ws@7.5.7/node_modules/ws/lib/websocket.js
../../node_modules/.pnpm/ws@7.5.7/node_modules/ws/index.js
../../node_modules/.pnpm/subscriptions-transport-ws@0.11.0/node_modules/subscriptions-transport-ws/dist/server.js
../../node_modules/.pnpm/subscriptions-transport-ws@0.11.0/node_modules/subscriptions-transport-ws/dist/index.js
../../node_modules/.pnpm/@graphql-tools+url-loader@7.9.7_@types+node@17.0.21/node_modules/@graphql-tools/url-loader/index.mjs
../../node_modules/.pnpm/@graphql-mesh+graphql@0.23.0_@types+node@17.0.21/node_modules/@graphql-mesh/graphql/index.mjs
./.graphclient/index.ts
./pages/index.tsx

../../node_modules/.pnpm/ws@7.5.7/node_modules/ws/lib/validation.js
Module not found: Can't resolve 'utf-8-validate' in '/home/feedme/interface/node_modules/.pnpm/ws@7.5.7/node_modules/ws/lib'

Import trace for requested module:
../../node_modules/.pnpm/ws@7.5.7/node_modules/ws/lib/receiver.js
../../node_modules/.pnpm/ws@7.5.7/node_modules/ws/index.js
../../node_modules/.pnpm/subscriptions-transport-ws@0.11.0/node_modules/subscriptions-transport-ws/dist/server.js
../../node_modules/.pnpm/subscriptions-transport-ws@0.11.0/node_modules/subscriptions-transport-ws/dist/index.js
../../node_modules/.pnpm/@graphql-tools+url-loader@7.9.7_@types+node@17.0.21/node_modules/@graphql-tools/url-loader/index.mjs
../../node_modules/.pnpm/@graphql-mesh+graphql@0.23.0_@types+node@17.0.21/node_modules/@graphql-mesh/graphql/index.mjs
./.graphclient/index.ts
./pages/index.tsx

../../node_modules/.pnpm/ws@8.5.0/node_modules/ws/lib/buffer-util.js
Module not found: Can't resolve 'bufferutil' in '/home/feedme/interface/node_modules/.pnpm/ws@8.5.0/node_modules/ws/lib'

Import trace for requested module:
../../node_modules/.pnpm/ws@8.5.0/node_modules/ws/lib/websocket.js
../../node_modules/.pnpm/ws@8.5.0/node_modules/ws/index.js
../../node_modules/.pnpm/isomorphic-ws@4.0.1_ws@8.5.0/node_modules/isomorphic-ws/node.js
../../node_modules/.pnpm/@graphql-tools+url-loader@7.9.7_@types+node@17.0.21/node_modules/@graphql-tools/url-loader/index.mjs
../../node_modules/.pnpm/@graphql-mesh+graphql@0.23.0_@types+node@17.0.21/node_modules/@graphql-mesh/graphql/index.mjs
./.graphclient/index.ts
./pages/index.tsx

../../node_modules/.pnpm/ws@8.5.0/node_modules/ws/lib/validation.js
Module not found: Can't resolve 'utf-8-validate' in '/home/feedme/interface/node_modules/.pnpm/ws@8.5.0/node_modules/ws/lib'

Import trace for requested module:
../../node_modules/.pnpm/ws@8.5.0/node_modules/ws/lib/receiver.js
../../node_modules/.pnpm/ws@8.5.0/node_modules/ws/index.js
../../node_modules/.pnpm/isomorphic-ws@4.0.1_ws@8.5.0/node_modules/isomorphic-ws/node.js
../../node_modules/.pnpm/@graphql-tools+url-loader@7.9.7_@types+node@17.0.21/node_modules/@graphql-tools/url-loader/index.mjs
../../node_modules/.pnpm/@graphql-mesh+graphql@0.23.0_@types+node@17.0.21/node_modules/@graphql-mesh/graphql/index.mjs
./.graphclient/index.ts
./pages/index.tsx

../../node_modules/.pnpm/@graphql-mesh+utils@0.27.9/node_modules/@graphql-mesh/utils/index.mjs
Critical dependency: the request of a dependency is an expression

Import trace for requested module:
./.graphclient/index.ts
./pages/index.tsx

../../node_modules/.pnpm/@graphql-mesh+utils@0.33.0/node_modules/@graphql-mesh/utils/index.mjs
Critical dependency: the request of a dependency is an expression

Import trace for requested module:
../../node_modules/.pnpm/@graphql-mesh+runtime@0.33.7/node_modules/@graphql-mesh/runtime/index.mjs
./.graphclient/index.ts
./pages/index.tsx

../../node_modules/.pnpm/@graphql-tools+url-loader@7.9.7_@types+node@17.0.21/node_modules/@graphql-tools/url-loader/index.mjs
Critical dependency: the request of a dependency is an expression

Import trace for requested module:
../../node_modules/.pnpm/@graphql-mesh+graphql@0.23.0_@types+node@17.0.21/node_modules/@graphql-mesh/graphql/index.mjs
./.graphclient/index.ts
./pages/index.tsx

Build error occurred
/home/feedme/interface/apps/analytics/.next/server/chunks/429.js:102418
resolveObjectURL ??= (webpack_require(14300).resolveObjectURL)
^^^

SyntaxError: Unexpected token '??='
at wrapSafe (internal/modules/cjs/loader.js:1001:16)
at Module._compile (internal/modules/cjs/loader.js:1049:27)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
at Module.load (internal/modules/cjs/loader.js:950:32)
at Function.Module._load (internal/modules/cjs/loader.js:790:12)
at Module.require (internal/modules/cjs/loader.js:974:19)
at require (internal/modules/cjs/helpers.js:101:18)
at Object.webpack_require.f.require (/home/feedme/interface/apps/analytics/.next/server/webpack-runtime.js:237:28)
at /home/feedme/interface/apps/analytics/.next/server/webpack-runtime.js:155:40
at Array.reduce () {
type: 'SyntaxError'`

[ardatan]

Actually GraphQL Tools and GraphQL Mesh have been tested on Node 12(which is lower than Node 14) and 17;
https://github.com/Urigo/graphql-mesh/blob/master/.github/workflows/tests.yml#L80
https://github.com/ardatan/graphql-tools/blob/master/.github/workflows/tests.yml#L115

I think the issue looks like something else specific for Vercel cc @dotansimha

[n1ru4l]

@matthewlilley This seems to be a webpack issue. Can you verify the same happens without bundling your AWS Lambda code? (fastify/fast-json-stringify#67)

[matthewlilley]

@n1ru4l I was able to run in Next.js development mode using both Node v14 & v16, still plenty of those errors such as

"Critical dependency: the request of a dependency is an expression" and "Module not found: Can't resolve 'utf-8-validate'"

but it still works fine in development mode

The breaking error is the "Unexpected token '??='" during a regular build

[matthewlilley]

Also, production build on Node v16 is successful and works fine. Node v14 is breaking with "Unexpected token '??='"

[n1ru4l]

@matthewlilley Can you give more context (e.g. a non-webpack butchered stack trace) on where that syntax error is happening? It seems like a dependency is using the Logical Assignment ??= feature, which is only supported since Node.js version 15.14.0.

[matthewlilley]

@n1ru4l I've struggled to find the exact dependency which is the trouble maker, but whenever the codegenerated SDK is used during build time it will bail with this error. I was able to avoid the error during build by using a dynamic import, but the error is still thrown at runtime during a function invocation.

This is the branch I'm working from:

https://github.com/sushiswap/interface/tree/feature/analytics

[n1ru4l]

@matthewlilley Can you please search your node_modules for usages of the ??= operator?

[matthewlilley]

@n1ru4l I've been speaking with the Vercel team about this issue and they've said that

"Since deps are not compiled when being used server-side, this error can't be avoided unless the child deps of graphql-mesh support v14 (even in GSSP)"

I searched node modules and could find no usages of ??= operator, only in the .next output folder. 🤔

[n1ru4l]

Does the occurence within the .next folder give some hint from where it originates? Maybe you can disable minification?

[matthewlilley]

[n1ru4l]

I narrowed it down using the GitHub search: https://github.com/search?p=3&q=schemeFetch&type=Code

https://github.com/nodejs/undici/blob/8b1dcd44755d7c9bfba06066518f4c01629ad1c0/lib/fetch/index.js#L794-L795

[matthewlilley]

@n1ru4l "It's a child dep of @graphql-mesh/types"

[n1ru4l]

I created nodejs/undici#1318