store/graph: add insensitive matching filters #3294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2022
tilacog
reviewed
Mar 1, 2022
Comment on lines
823
to
852
| | StartsWithInsensitive(attr, _) | ||
| | NotStartsWith(attr, _) | ||
| | NotStartsWithInsensitive(attr, _) | ||
| | EndsWith(attr, _) | ||
| | NotEndsWith(attr, _) => { | ||
| | EndsWithInsensitive(attr, _) | ||
| | NotEndsWith(attr, _) | ||
| | NotEndsWithInsensitive(attr, _) => { | ||
| table.column_for_field(attr)?; |
Contributor
There was a problem hiding this comment.
LGTM but it might be a sign that we could use a EntityFilter::attr(&self) -> Option<Attribute> getter method for conciseness.
Maybe we could open a new issue for this.
tilacog
reviewed
Mar 1, 2022
Comment on lines
-873
to
+911
|
|
||
| let operation = match (strict, negated) { | ||
| (true, true) => " not like ", | ||
| (true, false) => " like ", | ||
| (false, true) => " not ilike ", | ||
| (false, false) => " ilike ", | ||
| }; | ||
| match value { | ||
| Value::String(s) => { | ||
| out.push_identifier(column.name.as_str())?; | ||
| if negated { | ||
| out.push_sql(" not like "); | ||
| } else { | ||
| out.push_sql(" like ") | ||
| }; | ||
| out.push_sql(operation); |
tilacog
approved these changes
Mar 1, 2022
Collaborator
|
This might be bikeshedding, but could we rename the filters from |
Contributor
Author
|
updated @lutter :) |
lutter
approved these changes
Mar 7, 2022
Collaborator
lutter
left a comment
lutter
left a comment
There was a problem hiding this comment.
Thanks for making the change!
Contributor
|
@saihaj can this be merged? |
Contributor
Author
Yes @otaviopace I don't know if I am allowed to merge or if there are blog post or something we would want for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3293
Precede #3191