-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove typename from POI #3739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove typename from POI #3739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7131963 to
0e5117b
Compare
leoyvens
approved these changes
Jul 19, 2022
Collaborator
|
Nice work with the test! |
The test scenario added here shows a bug in the EntityCache where the __typename field wouldn't be cleared when it should. This was affecting the POI and mapping code determinism, it will be fixed in the next commit :)
After an entity merge, if the Entity Cache was cleared, the __typename field would come up again and polute mappings and by consequence, the POI. This commit fixes the issue/bug alongside with it's respective test.
7b2e857 to
40b7e32
Compare
b2873fd to
f629e90
Compare
5652fa7 to
b12a816
Compare
b10707c to
a53d930
Compare
leoyvens
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an entity merge, if the Entity Cache was cleared, the
__typenamefield would come up again and polute mappings and by consequence, the
POI. This PR fixes the issue/bug alongside with it's respective (new) test.
The merging behavior is described here in the docs (second item).