Filipe/substreams option runtime #3766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangas
force-pushed
the
filipe/substreams-option-host
branch
2 times, most recently
from
440277d to
3d977af
Compare
Collaborator
|
Why isn't it sufficient to use a fake |
Collaborator
|
Hmm I see that replacing the |
Contributor
Author
This way is also more explicit and requires less "hacks" IMO |
leoyvens
requested changes
Jul 22, 2022
mangas
force-pushed
the
filipe/substreams-option-host
branch
from
9b5a65b to
fe0f9c1
Compare
mangas
changed the title
mangas
force-pushed
the
filipe/substreams-option-host
branch
from
fe0f9c1 to
0786f72
Compare
leoyvens
requested changes
Jul 25, 2022
graph/src/data/subgraph/mod.rs
Outdated
| .map(|template| template.runtime()) | ||
| .chain(self.data_sources.iter().map(|source| source.runtime())) | ||
| .filter_map(|template| template.runtime()) | ||
| .chain(ds_runtimes.into_iter()) |
Collaborator
There was a problem hiding this comment.
This can be kept as it was before, just with filter_map instead of map.
mangas
force-pushed
the
filipe/substreams-option-host
branch
from
2bdfe51 to
e58839c
Compare
mangas
force-pushed
the
filipe/substreams-option-host
branch
from
e58839c to
5024c4c
Compare
leoyvens
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.