chore: sign update messages before sending #135
Conversation
pcarranzav
force-pushed
the
pcv/sign-every-update
branch
3 times, most recently
from
f4a87f5 to
e1e321c
Compare
|
Still in progress.
|
pcarranzav
force-pushed
the
pcv/sign-every-update
branch
from
ae96400 to
25b94a3
Compare
|
Still need to see if it works, but I think it's ready for review at this point |
apps/server/src/index.ts
Outdated
| @@ -1,5 +1,6 @@ | |||
| import { parse } from 'node:url'; | |||
| import { Identity, Messages, SpaceEvents, Utils } from '@graphprotocol/hypergraph'; | |||
| import { recoverUpdateMessageSigner } from '@graphprotocol/hypergraph/messages/signed-update-message'; | |||
There was a problem hiding this comment.
can you fix the import? afaik we should export it properly and not do deep imports
There was a problem hiding this comment.
Oops, missed this, will fix
| }); | ||
|
|
||
| space?.automergeDocHandle?.update((existingDoc) => { | ||
| const [newDoc] = automerge.applyChanges(existingDoc, automergeUpdates); |
There was a problem hiding this comment.
here we gather all the automergeUpdates and then apply them. I actually didn't do it properly in the other case, but this should be the way to go. Can you update the function to do it this way?
The reason is that afaik this is much more performant than applying ever update in a for loop
There was a problem hiding this comment.
Makes sense, will fix
|
Tested running the events app locally and can confirm updates are propagated correctly afaict |
2 participants
Closes #70
WIP