Skip to content

Conversation

@gusinacio
Copy link
Contributor

Fixes #380

@gusinacio gusinacio self-assigned this Oct 16, 2024
@coveralls
Copy link

coveralls commented Oct 16, 2024

Pull Request Test Coverage Report for Build 11391881490

Details

  • 139 of 152 (91.45%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 70.97%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent/sender_account.rs 78 91 85.71%
Files with Coverage Reduction New Missed Lines %
tap-agent/src/agent/sender_account.rs 3 91.78%
Totals Coverage Status
Change from base Build 11386312904: 0.3%
Covered Lines: 4618
Relevant Lines: 6507

💛 - Coveralls

carlosvdr
carlosvdr previously approved these changes Oct 17, 2024
Copy link
Contributor

@carlosvdr carlosvdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks overall good with me, id like to have a call about it if possible

Copy link
Contributor Author

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing a way to block the allocation from triggering another rav, while a rav is being executed.

@gusinacio gusinacio force-pushed the gustavo/tap-234-perf-allow-multiple-rav-requests-to-run-at-the-same-time branch from c01386c to b2fd691 Compare October 17, 2024 16:51
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio force-pushed the gustavo/tap-234-perf-allow-multiple-rav-requests-to-run-at-the-same-time branch from b2fd691 to 3973ed2 Compare October 17, 2024 16:51
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio force-pushed the gustavo/tap-234-perf-allow-multiple-rav-requests-to-run-at-the-same-time branch from 29eb89b to 3d6ea0d Compare October 17, 2024 18:41
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio force-pushed the gustavo/tap-234-perf-allow-multiple-rav-requests-to-run-at-the-same-time branch from 99e53bb to dcb80a4 Compare October 17, 2024 18:49
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio requested a review from carlosvdr October 17, 2024 19:43
@gusinacio gusinacio merged commit bb7b7c6 into main Oct 17, 2024
10 checks passed
@gusinacio gusinacio deleted the gustavo/tap-234-perf-allow-multiple-rav-requests-to-run-at-the-same-time branch October 17, 2024 21:06
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow multiple RAV requests to run at the same time

4 participants