Skip to content

Conversation

@gusinacio
Copy link
Contributor

Fixes #1009

@gusinacio gusinacio requested a review from carlosvdr October 7, 2024 12:10
@gusinacio gusinacio force-pushed the gusinacio/escrow-balance-check branch 3 times, most recently from 6275848 to 419e550 Compare October 7, 2024 12:20
@gusinacio gusinacio requested a review from dwerner October 7, 2024 12:23
@carlosvdr
Copy link
Contributor

Looks good to me, but was this tested in any way?

@carlosvdr
Copy link
Contributor

If there is any way to test through testnet or a local network would be nice to make sure this doesnt crash

@carlosvdr
Copy link
Contributor

Perhaps some unit test
Where you mock the tap Subgraph response for the escrow balance
To get the expected outcomes
One where it wont pass due to it not being enough and another test where it continues the desired path

@gusinacio gusinacio force-pushed the gusinacio/escrow-balance-check branch from 419e550 to 600608f Compare October 9, 2024 18:37
@gusinacio
Copy link
Contributor Author

gusinacio commented Oct 9, 2024

Hey @carlosvdr and @dwerner could you do another review here?

@carlosvdr
Copy link
Contributor

Oh yes this is nice! Works for me , great job :)

Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio force-pushed the gusinacio/escrow-balance-check branch from 34abfce to 08bc8ac Compare October 10, 2024 21:08
@gusinacio gusinacio merged commit 6548c42 into main Oct 10, 2024
10 checks passed
@gusinacio gusinacio deleted the gusinacio/escrow-balance-check branch October 10, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't redeem RAV if there's no escrow balance

4 participants