Skip to content

workflows: Update native modules precompile to include more Node versions #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2022
Merged

workflows: Update native modules precompile to include more Node versions #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b68d7d6
indexer-cli: Remove `--help` test that breaks when version changes
fordN Apr 29, 2022
0c8d30b
workflows: Improve node-abi coverage of precompiled native modules
fordN May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/publish-native-binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,12 @@ jobs:
# (https://github.com/bchr02/node-pre-gyp-github/issues/42)
fail-fast: false
matrix:
node_version: [12, 14, 16, 17]
node_version: [12, 13, 14, 15, 16]
system:
- os: macos-latest
target: x86_64-apple-darwin
- os: ubuntu-latest
target: x86_64-unknown-linux-gnu
include:
- node_version: 16
system:
os: macos-latest
target: aarch64-apple-darwin
runs-on: ${{ matrix.system.os }}
steps:
- name: Checkout the repo
Expand Down
6 changes: 0 additions & 6 deletions packages/indexer-cli/src/__tests__/cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@ describe('Indexer cli tests', () => {
afterEach(teardown)

describe('General', () => {
cliTest('help', ['--help'], 'references/help', {
expectedExitCode: 0,
cwd: baseDir,
timeout: 10000,
})

cliTest('Indexer help', ['indexer', '--help'], 'references/indexer-help', {
expectedExitCode: 255,
cwd: baseDir,
Expand Down
23 changes: 0 additions & 23 deletions packages/indexer-cli/src/__tests__/references/help.stdout
View file
Open in desktop

This file was deleted.