Skip to content

Update some of the dependencies #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 29, 2020
Merged

Update some of the dependencies #30

merged 4 commits into from
Apr 29, 2020

Conversation

@MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Apr 28, 2020 •
edited
Loading

@types/graphql is no longer required as the latest version of graphql provides its own type declarations.

@MaxDesiatov MaxDesiatov added the dependencies Pull requests that update a dependency file label Apr 28, 2020
@MaxDesiatov MaxDesiatov requested a review from czystyl April 28, 2020 09:11
@MaxDesiatov MaxDesiatov changed the title Update jest and its subdependencies Update jest, graphql-tools and their subdependencies Apr 28, 2020
@MaxDesiatov MaxDesiatov changed the title Update jest, graphql-tools and their subdependencies Update dependencies Apr 28, 2020
@MaxDesiatov MaxDesiatov changed the title Update dependencies Update some of the dependencies Apr 28, 2020
@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Apr 28, 2020

@czystyl unit-tests are fixed now, the new APIs require declaring directives explicitly now in a schema before using them. Also, now .toConfig() is explicitly used in tests to produce snapshots, the new API serializes directives as their names by default.

Ready for review 🙂

@czystyl
Copy link
Member

czystyl commented Apr 29, 2020

Nice! thank you for helping :)

@czystyl czystyl merged commit 63aba53 into master Apr 29, 2020
@czystyl czystyl deleted the maxd/update-jest branch April 29, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@czystyl czystyl czystyl approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaxDesiatov @czystyl