Use all fields when calculating types of arrays of objects #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #10. Sorry I figured this late.
I’ve been trying
graphql-compose-jsonin my project and realized that calculating types based on the first item of an array is not the best choice. If you have an array of objects returned from an API, some of those objects might omit some optional fields – and, as a result, those fields won’t get included into the generated schema.For example, for the following JSON:
the type of the
limbsproperty will be calculated roughly as follows:– and won’t include the
ringfield.This PR improves that by calling
getFieldConfigoverObject.assign({}, ...array)instead ofarray[0]. Technically, this is a breaking change, but given that 4.1.0 was released just yesterday, I doubt somebody got relying on the previous behavior.