Retrieving Headers from Response

[ThomasAunvik]

I have been having a problem where i have been trying to get headers from GraphQLResponse. And i have seen that it is possible for example in HttpRequest#Headers, but not in here, like for example i have been trying to get headers from Anilist so i could stop myself getting rate limited.

Is there a way to get headers from GraphQLResponse or GraphQLHttpClient?

[deinok]

Seems like we need a better way to handle the HttpInternal Middleware

[rose-a]

I suppose it would be best to add something like public Task<GraphQLResponse<TResponse>> SendQueryAsync<TResponse>(GraphQLRequest request, out HttpResponseHeaders headers, CancellationToken cancellationToken = default) to GraphQLHttpClient?

@sungam3r What's your opinion on this?

Edit: Async Methods can't have an out parameter...

[sungam3r]

A separate method with HttpResponseHeaders will not look very good. Where do you add it? GraphQLHttpClient ? Clients work with IGraphQLClient, I suppose.

I propose to add bool GraphQLHttpClientOptions.ReturnHeaders { get; set; } and Dictionary<string, string> GraphQLResponse<T>.AdditionalProperties . Naming is negotiable .

[sungam3r]

Or something like GraphQLHttpResponse<T> : GraphQLResponse<T> { Headers }

[rose-a]

Or something like GraphQLHttpResponse : GraphQLResponse { Headers }

This would certainly be the cleanest way, but it will not work when the websocket is used for sending queries/mutations (obviously, because there are no headers then).

I hope this is obvious to the consumers of this library, too... 🤔