Remove default serializer #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
reviewed
Mar 21, 2020
tests/GraphQL.Integration.Tests/GraphQL.Integration.Tests.csproj
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Mar 21, 2020
| }); | ||
| UseWebSocketForQueriesAndMutations = requestsViaWebsocket | ||
| }, | ||
| serializer ?? new NewtonsoftJsonSerializer()); |
Member
There was a problem hiding this comment.
Do you have tests for STJ serializer?
Collaborator
Author
There was a problem hiding this comment.
yes, there is always an abstract base class containing the tests and a specific testclass for each serializer (currently Newtonsoft and System.Text.Json)
Co-Authored-By: Ivan Maximov <sungam3r@yandex.ru>
Collaborator
Author
|
I think this requires a bump of the major version of this library (as it's a breaking change)... @sungam3r Whats your opinion on this? |
Member
|
Yes. Personally I am OK with breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #188