don't use ImmutableConverter for nullable structs #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wirmar
force-pushed
the
fix/234_nullableStructSerialization
branch
from
840cd21 to
99814cc
Compare
sungam3r
reviewed
May 27, 2020
|
|
||
| var nullableUnderlyingType = Nullable.GetUnderlyingType(typeToConvert); | ||
| if (nullableUnderlyingType != null && nullableUnderlyingType.IsPrimitive) | ||
| if (nullableUnderlyingType != null && nullableUnderlyingType.IsValueType) |
Contributor
Author
There was a problem hiding this comment.
What exactly do you mean by this review? 😄
Member
There was a problem hiding this comment.
The devil is in the little things.
Collaborator
|
Thanks for fixing this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #234