Skip to content

GraphQLRequest fixes #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2020
Merged

GraphQLRequest fixes #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
151e733
preserve all entries in GraphQLRequest
bjorg Oct 6, 2020
840da16
make copy constructor more specific
bjorg Oct 6, 2020
2dd397d
use Dictionary copy constructor on new GraphQLRequest constructor
rose-a Oct 15, 2020
15f1045
fix GraphQLRequest.GetHastCode()
rose-a Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/GraphQL.Client/GraphQLHttpRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public GraphQLHttpRequest(string query, object? variables = null, string? operat
{
}

public GraphQLHttpRequest(GraphQLRequest other): base(other.Query, other.Variables, other.OperationName)
public GraphQLHttpRequest(GraphQLRequest other): base(other)
{
}

Expand Down
13 changes: 3 additions & 10 deletions src/GraphQL.Primitives/GraphQLRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ public GraphQLRequest(string query, object? variables = null, string? operationN
OperationName = operationName;
}

public GraphQLRequest(GraphQLRequest other): base(other) { }

/// <summary>
/// Returns a value that indicates whether this instance is equal to a specified object
/// </summary>
Expand Down Expand Up @@ -82,16 +84,7 @@ public virtual bool Equals(GraphQLRequest? other)
/// <summary>
/// <inheritdoc cref="object.GetHashCode"/>
/// </summary>
public override int GetHashCode()
{
unchecked
{
var hashCode = Query.GetHashCode();
hashCode = (hashCode * 397) ^ OperationName?.GetHashCode() ?? 0;
hashCode = (hashCode * 397) ^ Variables?.GetHashCode() ?? 0;
return hashCode;
}
}
public override int GetHashCode() => (Query, OperationName, Variables).GetHashCode();

/// <summary>
/// Tests whether two specified <see cref="GraphQLRequest"/> instances are equivalent
Expand Down