fix: removed the utf-8 encoding from the PostAsync fucntion #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM, but i will take a closer look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the utf-8 encoding from the StringContent parameter list and moved it to the MediaType value in GraphQLClientOptions class. The reason to do this was the API which I'm connecting rejects the uft-8 encoding along with ContentType as 'application/json'. So to allow clients to customize the ContentType and not restrict them to use utf-8 encoding I have updated the GraphQLClientOptions.MediaType property's default value.
I have also added a new test that proves that ContentType without utf-8 encoding work along with all the existing tests. I would have added more test to assert the default media/content type contains utf-8 from the request but unfortunately the GraphQLClient doesn't expose the httpClient.
Please let me know if you have any queries or suggestions.