-
Notifications
You must be signed in to change notification settings - Fork 136
Use single websocket for all subscriptions #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
deinok
merged 21 commits into
graphql-dotnet:subscriptions-api
from
rose-a:use-single-websocket-for-all-subscriptions
Dec 11, 2018
Merged
Use single websocket for all subscriptions #84
deinok
merged 21 commits into
graphql-dotnet:subscriptions-api
from
rose-a:use-single-websocket-for-all-subscriptions
Dec 11, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi, @rose-a I'm porting all the code to use https://docs.microsoft.com/en-us/dotnet/csharp/tutorials/nullable-reference-types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've worked a bit on the API and restructured it to use a single web socket for all subscriptions made on a
GraphQLHttpClient.I've also added some ways to customize error handling and to automatically reconnect in case of a connection loss without having to re-create the whole subscription.
From here we're also not far from being able to use the client in "full websocket mode", meaning that regular queries and mutations also would use the websocket connection instead of sending separate POST requests for each query. This is also supported by the Apollo GraphQL server and the graphql-dotnet/server middleware.
What's still missing is an automated test to confirm the reconnect working, because I did not find any way to programmatically restart Kestrel within a XUnit test. I had to test this one manually using the
IntegrationTestServerapp and theSubscriptionIntegrationTest.ConsoleClientconsole app.This PR relates to #25