🐛 directive removal should not be considered node removal - to many places

Author: aexol

package.json

@@ -1,6 +1,6 @@
 {
   "name": "graphql-js-tree",
-  "version": "0.2.6",
+  "version": "0.2.7",
   "private": false,
   "license": "MIT",
   "description": "GraphQL Parser providing simplier structure",

src/TreeOperations/tree.ts

@@ -118,17 +118,6 @@ export const mutate = (tree: ParserTree, allNodes: ParserField[]) => {
       }
       return;
     }
-    if (node.data.type === Instances.Argument) {
-      const parent = allNodes.find((p) => p.directives.some((a) => a.args.includes(node)));
-      if (parent) {
-        const parentDirective = parent.directives.find((d) => d.args.some((a) => a === node));
-        if (parentDirective) {
-          const indexInDirective = parentDirective.args.indexOf(node);
-          deleteFieldFromNode(parentDirective, indexInDirective);
-        }
-      }
-      return;
-    }
     if (node.data.type === ValueDefinition.InputValueDefinition) {
       const parent = allNodes.find((parentNode) => parentNode.args.includes(node));
       if (parent) {
@@ -152,6 +141,12 @@ export const mutate = (tree: ParserTree, allNodes: ParserField[]) => {
       }
       return;
     }
+    if (node.data.type === Instances.Directive) {
+      throw new Error('Directives should be removed on node directly not using this function');
+    }
+    if (node.data.type === Instances.Argument) {
+      throw new Error('Directive Arguments should be removed on node directly not using this function');
+    }
     const deletedNode = tree.nodes.findIndex((n) => n === node);
     if (deletedNode === -1) throw new Error('Error deleting a node');
     // co jak usuwamy extension interface

src/__tests__/TreeOperations/tree.remove.spec.ts

@@ -48,11 +48,13 @@ describe('Tree Operations - node removal tests', () => {
     expect(treeMock.nodes[1].args[1].id).not.toEqual(oldFieldId);
     expect(treeMock.nodes[1].id).not.toEqual(oldQueryId);
   });
+  test('Delete directive from node', () => {
+    const treeMock = createMock();
+    expect(() => mutate(treeMock, treeMock.nodes).removeNode(treeMock.nodes[0].directives[0])).toThrowError();
+  });
   test('Delete argument node from Directive Instance', () => {
     const treeMock = createMock();
-    const oldArgument = JSON.parse(JSON.stringify(treeMock.nodes[0].directives[0].args[0]));
-    mutate(treeMock, treeMock.nodes).removeNode(treeMock.nodes[0].directives[0].args[0]);
-    expect(treeMock.nodes[0].directives[0].args).not.toContainEqual(oldArgument);
+    expect(() => mutate(treeMock, treeMock.nodes).removeNode(treeMock.nodes[0].directives[0].args[0])).toThrowError();
   });
   test('Delete union member from union node', () => {
     const treeMock = createMock();