Skip to content

Fix flaky unit test in lib/core/usage.spec.ts #6503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix flaky unit test in lib/core/usage.spec.ts #6503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 6 additions & 19 deletions packages/libraries/core/tests/usage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ test('should send data to Hive (deprecated endpoint)', async () => {
expect(operation.execution.ok).toBe(true);
});

test('should not leak the exception', { retry: 3 }, async () => {
test('should not leak the exception', async () => {
const logger = createHiveTestingLogger();

const hive = createHive({
Expand Down Expand Up @@ -374,7 +374,7 @@ test('should not leak the exception', { retry: 3 }, async () => {
`);
});

test('sendImmediately should not stop the schedule', { retry: 3 }, async () => {
test('sendImmediately should not stop the schedule', async () => {
const logger = createHiveTestingLogger();

const token = 'Token';
Expand Down Expand Up @@ -431,34 +431,21 @@ test('sendImmediately should not stop the schedule', { retry: 3 }, async () => {
// since we sent only 1 element, the buffer was not full,
// so we should not see "Sending immediately"

expect(logger.getLogs()).toMatchInlineSnapshot(`
[INF] [hive][usage] Sending report (queue 1)
[INF] [hive][usage] POST http://localhost/200 (x-request-id=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx)
[INF] [hive][usage] POST http://localhost/200 (x-request-id=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx) succeeded with status 200 (666ms).
[INF] [hive][usage] Report sent!
`);
expect(logger.getLogs()).not.toMatch('Sending immediately');
logger.clear();

// Now we will hit the maxSize
// We run collect two times
await Promise.all([collect(args, {}), collect(args, {})]);
await waitFor(1);
expect(logger.getLogs()).toMatchInlineSnapshot(`
[INF] [hive][usage] Sending immediately
[INF] [hive][usage] Sending report (queue 2)
[INF] [hive][usage] POST http://localhost/200 (x-request-id=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx)
`);
expect(logger.getLogs()).toMatch('Sending immediately');
expect(logger.getLogs()).toMatch('Sending report (queue 2)');
logger.clear();
await waitFor(100);
// Let's check if the scheduled send task is still running
await collect(args, {});
await waitFor(40);
expect(logger.getLogs()).toMatchInlineSnapshot(`
[INF] [hive][usage] POST http://localhost/200 (x-request-id=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx) succeeded with status 200 (666ms).
[INF] [hive][usage] Report sent!
[INF] [hive][usage] Sending report (queue 1)
[INF] [hive][usage] POST http://localhost/200 (x-request-id=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx)
`);
expect(logger.getLogs()).toMatch('Sending report (queue 1)');

await hive.dispose();
http.done();
Expand Down
Loading