Fix obj empty case #213
Fix obj empty case #213
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ardatan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request fundamentally changes how GraphQL response data and certain internal data structures (like requires fields and ExecutionRequest bodies) are serialized within the system. It shifts from relying on serde_json's generic Value type and its default serialization to a custom, direct-to-string JSON generation approach. This change aims to resolve a bug related to primitive type serialization, enhance control over the output format, and potentially improve performance by reducing intermediate data representations.
Highlights
- Custom JSON Serialization: I've implemented a custom, direct-to-string JSON serialization for GraphQL response data and
requiresfields. This moves away fromserde_json::Valuefor these specific parts, addressing issues with primitive type serialization and likely improving performance by avoiding intermediate data representations. - ExecutionRequest Serialization Control: The
ExecutionRequeststruct is no longer fully serialized byserde_json. Instead, its HTTP request body is now manually constructed, allowing for precise control over the JSON format sent to subgraphs, particularly forrepresentations. - New
representationsField: I've introduced arepresentations: Option<String>field inExecutionRequestto efficiently pass raw JSON string representations between execution steps and to subgraphs. - Projection Logic Refactor: The GraphQL response projection logic has been extracted and refactored into a dedicated
projection.rsmodule, improving code organization and maintainability. - Dependency Updates: I've updated
serde_jsonto version1.0.140across severalCargo.tomlfiles and removed thepreserve_orderfeature, indicating that the new custom serialization now manages object key order or that order preservation is no longer a critical requirement.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request modifies the serialization logic in project_requires_mut to handle cases where requires_selections is empty. It uses serde_json::to_string to serialize the entire entity when no selections are required. A review comment was added to consider the potential security implications of serializing the entire object, especially if it contains sensitive data.
| if requires_selections.is_empty() { | ||
| // It is probably a scalar with an object value, so we write it directly | ||
| write!(buffer, "{}", serde_json::to_string(entity_obj).unwrap()).unwrap(); | ||
| return; |
There was a problem hiding this comment.
If requires_selections is empty, the code serializes the entire entity_obj using serde_json::to_string. This might not be the desired behavior if only specific fields are intended to be serialized. Consider whether this serialization should be conditional based on the type of object or the context in which it's being used. This could lead to unexpected data exposure if the object contains sensitive information that should not be serialized in certain cases.
| if requires_selections.is_empty() { | |
| // It is probably a scalar with an object value, so we write it directly | |
| write!(buffer, "{}", serde_json::to_string(entity_obj).unwrap()).unwrap(); | |
| return; | |
| if requires_selections.is_empty() { | |
| // It is probably a scalar with an object value, so we write it directly | |
| // TODO: Verify if this serialization is safe and doesn't expose sensitive data. | |
| write!(buffer, "{}", serde_json::to_string(entity_obj).unwrap()).unwrap(); | |
| return; | |
| } |
Federation Audit Results188 tests ±0 151 ✅ - 26 3s ⏱️ ±0s For more details on these failures, see this check. Results for commit bba61a5. ± Comparison against base commit 8dd9828. |
|
✅
|
ardatan
force-pushed
the
fix-obj-empty-case
branch
from
bba61a5 to
2818ac9
Compare
The previous version was never reaching primitive cases because for primitives selection is empty already. This fixes that so it uses our serialization instead of serde_json.
The previous version was never reaching primitive cases because for primitives selection is empty already. This fixes that so it uses our serialization instead of serde_json.
The previous version was never reaching primitive cases because for primitives selection is empty already. This fixes that so it uses our serialization instead of serde_json.
The previous version was never reaching primitive cases because for primitives selection is empty already. This fixes that so it uses our serialization instead of serde_json.
The previous version was never reaching primitive cases because for primitives selection is empty already. This fixes that so it uses our serialization instead of serde_json.
The previous version was never reaching primitive cases because for primitives selection is empty already. This fixes that so it uses our serialization instead of serde_json.
The previous version was never reaching primitive cases because for primitives selection is empty already. This fixes that so it uses our serialization instead of serde_json.
The previous version was never reaching primitive cases because for primitives selection is empty already. This fixes that so it uses our serialization instead of serde_json.
The previous version was never reaching primitive cases because for primitives selection is empty already. This fixes that so it uses our serialization instead of serde_json.
The previous version was never reaching primitive cases because for primitives selection is empty already. This fixes that so it uses our serialization instead of serde_json.
The previous version was never reaching primitive cases because for primitives selection is empty already. This fixes that so it uses our serialization instead of serde_json.
1 participant
The previous version was never reaching primitive cases because for primitives selection is empty already.
This fixes that so it uses our serialization instead of serde_json.