Merge pull request #3 from denvned/patch-2

Omit mutation object when there are no mutations

Author: yrashk

src/main/java/graphql/servlet/GraphQLServlet.java

@@ -68,7 +68,6 @@ public class GraphQLServlet extends HttpServlet implements Servlet, GraphQLMBean
 
     protected void updateSchema() {
         GraphQLObjectType.Builder object = newObject().name("query");
-        GraphQLObjectType.Builder mutationObject = newObject().name("mutation");
 
         for (GraphQLQueryProvider provider : queryProviders) {
             GraphQLObjectType query = provider.getQuery();
@@ -80,12 +79,19 @@ protected void updateSchema() {
                     build());
         }
 
-        for (GraphQLMutationProvider provider : mutationProviders) {
-            provider.getMutations().forEach(mutationObject::field);
-        }
-
         readOnlySchema = newSchema().query(object.build()).build();
-        schema = newSchema().query(object.build()).mutation(mutationObject.build()).build();
+
+        if (mutationProviders.isEmpty()) {
+            schema = readOnlySchema;
+        } else {
+            GraphQLObjectType.Builder mutationObject = newObject().name("mutation");
+
+            for (GraphQLMutationProvider provider : mutationProviders) {
+                provider.getMutations().forEach(mutationObject::field);
+            }
+
+            schema = newSchema().query(object.build()).mutation(mutationObject.build()).build();
+        }
     }
 
     public GraphQLServlet() {

src/test/java/graphql/servlet/GraphQLServletTest.java

@@ -90,7 +90,7 @@ public void mutationProvider() {
         assertTrue(servlet.schema.getMutationType().getFieldDefinition("int").getType().equals(GraphQLInt));
         assertNull(servlet.readOnlySchema.getMutationType());
         servlet.unbindMutationProvider(mutationProvider);
-        assertTrue(servlet.schema.getMutationType().getFieldDefinitions().isEmpty());
+        assertNull(servlet.schema.getMutationType());
     }
 
     @Test @SneakyThrows