This repository was archived by the owner on Dec 19, 2023. It is now read-only.
chore: build script improvements, Gradle upgrade to 6.2.2 #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
@BlasiusSecundus Could you resolve the merge conflicts so I can go ahead and merge it? |
Notable improvements: - upgrade Gradle Wrapper to version 6.2.2 - add the Official Gradle Wrapper Validation Action (https://github.com/gradle/wrapper-validation-action) - use Spring dependency management - all dependency versions defined in gradle.properties (excluding those only used in examples) - update some dependency and plugin versions - update deprecated `compile` / `runtime` dependency configurations (replaced with `implementation` or `api` / `runtimeOnly`) - remove deprecated `maven` plugin - remove Lombok plugin (Lombok version is now managed by Spring) Potential breaking changes: - the `install` task no longer exists; use `publishToMavenLocal` instead - Lombok-related tasks were removed
BlasiusSecundus
force-pushed
the
feature/build-script-refactor
branch
from
d3b5ac0 to
e7bb2ff
Compare
|
Conflicts resolved. However, I could not make Voyager work, always got 404 (GraphiQL, Playground and Altair works file). Also, I have not yet tested the reactive versions. |
BlasiusSecundus
changed the title
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable improvements:
(https://github.com/gradle/wrapper-validation-action)
(excluding those only used in examples)
compile/runtimedependency configurations(replaced with
implementationorapi/runtimeOnly)mavenpluginPotential breaking changes:
installtask no longer exists; usepublishToMavenLocalinsteadNote
This is quite a refactor and I hope that nothing is broken:) I have tested basic tasks like
check,publishToMavenLocaletc. Also some tasks of the release plugin (e. g.unSnapshot,updateVersion).I did not test (nor touched the configuration) of the Bintray plugin.
Please review / test it thoroughly to ensure that all necessary tasks still works as expected.